fix: resolve PR #42 review comments - #44
Merged
Merged
Conversation
…sole - Remove superfluous restated-in-AGENTS.md comments (game.ts, admin-player-activity.ts) - Dedupe GAME_PERFORMANCE_SORT_FIELDS between the contract port and admin-console - Add a currency filter to the game-performance report instead of summing cross-currency amounts together - Rewrite DAU/WAU/MAU to a single LEFT JOIN + FILTER instead of three correlated subqueries per generated day - Fix a retention off-by-one: the registration-day session no longer counts as a return, window now starts the day after registration - Use Drizzle column references instead of hardcoded snake_case identifiers in the retention query - Add a TODO documenting that winAmount is never set yet (endRound has no way to report a win), so revenue always equals volume today - Rewrite the DrizzleAdminGameReporting, DrizzleAdminPlayerActivity, and BackofficeService.getGamePerformance test suites against real Postgres instead of mocked query builders/ports Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019sDfSQ52GKxqKPsP3k4Uer
marek-chmielowski-blurify
marked this pull request as ready for review
July 29, 2026 12:04
marek-chmielowski-blurify
requested review from
agniev-a-hub,
klaudia-blazyczek-blurify and
zaxovaiko
as code owners
July 29, 2026 12:04
agniev-a-hub
previously approved these changes
Jul 29, 2026
agniev-a-hub
left a comment
agniev-a-hub
left a comment
Collaborator
There was a problem hiding this comment.
Filtering is WARN.
- fix retention cohort window to anchor on the cohort's calendar day instead of the exact registration timestamp, so a user returning the next calendar day but under 24h after registering is still counted - remove now-unused registered_at column from the retention CTE - remove TODO on winAmount per reviewer request - document the no-currency-filter mixed-currency sum as intentional Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015cusuRvKBX3sJnFxqfkcPE
marek-chmielowski-blurify
requested review from
agniev-a-hub and
klaudia-blazyczek-blurify
July 30, 2026 09:07
klaudia-blazyczek-blurify
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all 10 unresolved review comments left on #42 (merged without addressing them).
AGENTS.md/naming already documents (game.ts,admin-player-activity.ts)GAME_PERFORMANCE_SORT_FIELDSbetween the contract port and admin-console (import from@openora/core/contractsinstead of redeclaring)currencyfilter to the game-performance report instead of summing bet/win amounts across currenciesLEFT JOIN+FILTERinstead of three correlated subqueries per generated dayTODOdocumenting thatwinAmountis never set yet (endRoundhas no way to report a win), so revenue currently always equals volumeDrizzleAdminGameReporting,DrizzleAdminPlayerActivity, andBackofficeService.getGamePerformancetest suites against real Postgres instead of mocked query builders/portsTest plan
pnpm verify(types, lint, boundaries, shape, deprecations, unit tests, drift) - green