test: add unit test suite for AutoComplete module - #126
Merged
Conversation
bobbylight
force-pushed
the
add-test-coverage-and-uimanager-style-context
branch
4 times, most recently
from
August 25, 2026 03:27
5ff5929 to
b245228
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
bobbylight
force-pushed
the
add-test-coverage-and-uimanager-style-context
branch
from
August 26, 2026 01:30
b245228 to
7df9c76
Compare
bobbylight
marked this pull request as ready for review
August 26, 2026 01:33
bobbylight
force-pushed
the
add-test-coverage-and-uimanager-style-context
branch
2 times, most recently
from
August 26, 2026 02:28
2ecdc23 to
f385de8
Compare
Adds JUnit 5 test coverage across the autocomplete package (completions, providers, renderers, XML parsing, UI helpers), makes AutoCompletionStyleContext colors overridable via UIManager keys with cached fallbacks, and simplifies SizeGrip's OS-X detection/resource-loading logic to be testable. Co-Authored-By: Claude <noreply@anthropic.com>
bobbylight
force-pushed
the
add-test-coverage-and-uimanager-style-context
branch
from
August 26, 2026 02:36
f385de8 to
e9df271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a JUnit 5 unit test suite covering most of the
org.fife.ui.autocompletepackage, and makesAutoCompletionStyleContext's colors overridable viaUIManagerkeys so LookAndFeels/apps can theme them without subclassing.Details
BasicCompletion,FunctionCompletion,VariableCompletion,TemplateCompletion,MarkupTagCompletion,ShorthandCompletion), providers (DefaultCompletionProvider,LanguageAwareCompletionProvider), renderers (CompletionCellRenderer,DelegatingCellRenderer),RoundRobinAutoCompletion, XML parsing (CompletionXMLParser), and several smaller UI helper classes (SizeGrip,FastListUI,TipUtil,EmptyIcon,OutlineHighlightPainter,CompletionListModel,AutoCompletionEvent).AutoCompletionStyleContextnow exposes publicUIManagerkey constants (PROPERTY_PARAMETER_OUTLINE_COLOR,PROPERTY_PARAMETER_COPY_COLOR,PROPERTY_PARAMETERIZED_COMPLETION_CURSOR_POSITION_COLOR) and reads fromUIManagerfirst, falling back to the existing hardcoded defaults (cached back intoUIManagerasColorUIResource, matching the existingautocomplete.descWindow.*icon-key convention).SizeGrip's OS-X detection and resource-loading logic was simplified (usesOS.get()instead of parsingos.name, drops a dead file-system fallback path) to make it unit-testable.Test plan
./gradlew clean buildpasses locally (checkstyle, spotbugs, and the full test suite).🤖 Generated with Claude Code