Repository navigation
refactor: centralize renderer directive constants - #162
Merged
Merged
Conversation
Contributor
No changeset neededThis pull request is classified as no_release_impact: no published package |
commit: |
|
Size Increased — +0.0 KB 129.4 KB unpacked |
This was referenced Oct 23, 2026
cowboyd
added this pull request to stack #165
October 23, 2026 14:26
gameroman
approved these changes
Oct 23, 2026
gameroman
left a comment
gameroman
left a comment
Member
There was a problem hiding this comment.
one comment otherwise looks good 👍
Comment on lines
-771
to
-774
| // initialize back buffer with spaces and default fg/bg | ||
| cells_fill(ct->back, w, h, ' ', ATTR_DEFAULT, ATTR_DEFAULT); | ||
|
|
||
| // initialize front buffer with zeros. Every cell will be |
Member
There was a problem hiding this comment.
were these removed on purpose?
Collaborator
Author
There was a problem hiding this comment.
They were as they seemed a bit obvious, but I'll add them back.
Member
There was a problem hiding this comment.
That’s fine, just wanted to make sure if it’s by accident or not 👍
6 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the renderer's existing opcode and property-mask constants from
clayterm.cintoclayterm.hwith theCLAYTERM_prefix, keeping their numeric values unchanged. Remove unusedOP_BEGIN_LAYOUTandOP_END_LAYOUTdefinitions, correct the header reference inops.ts, and remove obsolete or incomplete buffer comments.No separate issue is needed for this mechanical internal cleanup.
Validation: the rebuilt WASM is byte-for-byte identical to baseline
75fbd0c. All 29 test suites (385 steps),deno task verify, anddeno lintpass.Type of change
Checklist
deno task test)deno task fmt)AI-generated code disclosure