Repository navigation
Conversation
Contributor
Changeset suggestionThe current changeset no longer matches this PR. This review contains a corrected replacement. Why: Changeset package scope does not match the affected packages confidently. Changeset is not sufficiently consumer-focused. View the proposed changeset---
'@bomb.sh/tty': patch
---
TODO: Write changeset message (inference failed: HTTP 401: {"error":{"message":"User not found.","code":401}})Review this changeset manually If this draft is correct, react with 🚀 and Cooper will commit it to this branch. |
![bombshell-cooper[bot]](https://avatars.githubusercontent.com/in/4226441?s=60&v=4){kind=small}
| @@ -0,0 +1,5 @@ | |||
| --- | |||
Contributor
There was a problem hiding this comment.
Changeset needs revision.
Changeset package scope does not match the affected packages confidently. Changeset is not sufficiently consumer-focused.
View the proposed replacement
---
'@bomb.sh/tty': patch
---
TODO: Write changeset message (inference failed: HTTP 401: {"error":{"message":"User not found.","code":401}})
commit: |
|
Size Reduced — -0.1 KB 129.3 KB unpacked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
render coordinates used
(int)casts, which truncate toward zero, so anything between y = -1 and 0 drew on row 0 (a panel sliding in from above stacked its rows there). now edges round withceilf(v - 0.5)to the cell whose center they coverthe hit test needed one more piece to agree with that: clay's
Clay__PointIsInsideRectincludes both edges, so when an edge lands exactly on a cell center both elements get the pointer. this happens on plain oddgrow()splits too (two siblings in 41 columns are 20.5 wide).patches/clay-half-open-hit-test.patchmakes the bottom and right edges exclusiveadded renderer-spec §7.11 (cell coverage) and pointed §12.4 at it.
test/coverage.test.tssweeps a panel from y = -3 to 1 and checks the pointer hits exactly the row drawn in every cellheads up: fractional edges past the middle of a cell now round up instead of down, a 3-way split of 40 columns starts the third element at 27 instead of 26. no existing test changed
closes #151
Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure