feat: discover registered Waku programmatic pages - #15
Open
bompus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discover literal Waku
createPagedeclarations inside registeredcreatePagescallbacks. Routes bind exact named local or imported component functions, including async registration and aliases. Static paths and exact-path declarations reuse filesystem path handling. Computed declarations, shadowed helpers, nested functions, and declarations after potentially terminating control flow are excluded.Validated against the pinned 1.0.0-rc.0 official typegen fixture, plus scoped/reopened sync, filesystem-to-programmatic transitions and fresh compiled workers. Build passes; 146 WASM focused/control tests pass; full native suite: 4,632 passed, 46 skipped. Independent correctness and complexity review is clear after fixing unreachable declarations following conditional returns.
Completes all 13 approved application-router coverage steps. This PR is stacked on Waku filesystem support (#14).