Allow referencing the types of nested properties - #14
Open
ncguilbeault wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnumerateTypeHierarchyonly walked the interfaces and base chain of the source type, so the type of any property was never registered with the custom type provider and could not be named in an expression. This PR introduces a change toEnumerateTypeHierarchyto traverse the types of properties as well, and a guard was put in place to ensure visited types only register once, to prevent infinite recursion from types that reference each other.One caveat to this approach compared to before is that each newly visited type contributes its own base chain and interfaces, so complex types can produce a fairly deep hierarchy. It may be worth bounding the traversal by depth, or skipping certain types if size becomes a problem.
Fixes #13