Closed
Align survFit docs with centered linear predictor behavior for newdata = NULL#123
survFit docs with centered linear predictor behavior for newdata = NULL#123Conversation
Copilot
AI
changed the title
[WIP] Fix code as per review comment
Align Jul 23, 2026
survFit docs with centered linear predictor behavior for newdata = NULL
fabian-s
pushed a commit
to fabian-s/mboost
that referenced
this pull request
Jul 23, 2026
…behavior Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HqB9XX7JjdQJ1vah4eyWv9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review comment on PR #122 highlighting a documentation/behavior mismatch in
survFit. The docs previously saidnewdata = NULLcomputes survival for “mean covariates,” while the implementation centers the linear predictor.What changed
man/survFit.Rd(\details{}) to describenewdata = NULLbehavior as based on a centered linear predictor rather than “mean of the covariates.”Doc wording adjustment