Skip to content

Fix msvc warning unreachable code #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
autoantwort wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −4
Open

Fix msvc warning unreachable code #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
147be90
Fix msvc warning unreachable code
Aug 12, 2026
9700f08
Fix msvc warning unreachable code
Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions include/boost/optional/detail/optional_reference_spec.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,10 @@ class optional<T&> : public optional_detail::optional_tag

constexpr T& value() const
{
return this->is_initialized() ?
this->get() :
(boost::throw_exception(boost::bad_optional_access()), this->get());
if (!this->is_initialized()) {
boost::throw_exception(boost::bad_optional_access());
}
return this->get();
}

constexpr explicit operator bool() const BOOST_NOEXCEPT { return ptr_ != 0; }
Expand Down
5 changes: 4 additions & 1 deletion include/boost/optional/detail/union_optional.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,10 @@ namespace boost {

constexpr reference_const_type value() const&
{
return this->is_initialized() ? this->get() : (boost::throw_exception(boost::bad_optional_access()), this->get());
if (this->is_initialized())
return this->get();
else
boost::throw_exception(boost::bad_optional_access());
}

BOOST_CXX14_CONSTEXPR reference_type value() &
Expand Down