Add a regression test for cross-library base pointer deserialization#351
Merged
Conversation
A derived class defined in a shared library is round-tripped through a `unique_ptr` to its abstract base, across the library boundary, using a binary-backed polymorphic archive, from an executable built with hidden symbol visibility. The test reuses the existing `dll_polymorphic_base` and `dll_polymorphic_derived2` libraries. On GCC/ELF the per-type serializer singletons were duplicated across the boundary, so the reader could not map the class id back to the derived type and recovered the wrong object. Refs issue #117.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A derived class defined in a shared library is round-tripped through a
unique_ptrto its abstract base, across the library boundary, using a binary-backed polymorphic archive, from an executable built with hidden symbol visibility. The test reuses the existingdll_polymorphic_baseanddll_polymorphic_derived2libraries.On GCC/ELF the per-type serializer singletons were duplicated across the boundary, so the reader could not map the class id back to the derived type and recovered the wrong object.
Refs issue #117.