fix: XML archive closes a completed document even while unwinding - #361
Merged
gennaroprota merged 1 commit intoJul 30, 2026
Merged
Conversation
The XML output archive writes the closing `</boost_serialization>` tag in its destructor, but skipped it whenever an exception was unwinding the stack (`uncaught_exceptions() > 0`). That guard cannot tell an interrupted serialization from a completed one: when a fully written archive happened to be destroyed during unwinding for an unrelated reason (e.g. a later throw), its closing tag was silently dropped, leaving a corrupt file that fails to load (and, via #220, terminates the reader). So, always try to add the closing tag when the document is complete. Fixes #188.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML output archive writes the closing
</boost_serialization>tag in its destructor, but skipped it whenever an exception was unwinding the stack (uncaught_exceptions() > 0). That guard cannot tell an interrupted serialization from a completed one: when a fully written archive happened to be destroyed during unwinding for an unrelated reason (e.g. a later throw), its closing tag was silently dropped, leaving a corrupt file that fails to load (and, via #220, terminates the reader).So, always try to add the closing tag when the document is complete.
Fixes #188.