Repository navigation
refactor(json)!: remove parseJson - #575
Open
MaksymStoianov wants to merge 3 commits into
Open
MaksymStoianov wants to merge 3 commits into
MaksymStoianov wants to merge 3 commits into
Conversation
parseJson was deprecated. Its relaxed reader re-quoted single-quoted strings incorrectly (CodeQL js/incomplete-sanitization); instead of fixing a deprecated function, it is removed in 3.0.0. Use JSON.parse. Removed: the function and its tests, the docs pages in five languages, their table-of-contents and reference entries, and the see-also link from stringifyJson. BREAKING CHANGE: parseJson is no longer exported; use JSON.parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Maksym Stoianov <stoianov.maksym@gmail.com>
…rse-json Signed-off-by: Maksym Stoianov <stoianov.maksym@gmail.com> # Conflicts: # src/json/parseJson.ts # test/json/parseJson.test.ts
…rse-json Signed-off-by: Maksym Stoianov <stoianov.maksym@gmail.com> # Conflicts: # src/json/parseJson.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseJsonwas deprecated; it is removed in 3.0.0 instead of fixing it. Its relaxed reader re-quoted single-quoted strings incorrectly (CodeQL alerts 7–8,js/incomplete-sanitization). UseJSON.parse.Removed: the function and its tests, the docs pages in five languages, their table-of-contents and reference entries, the authored docs entry and the see-also link from
stringifyJson.bootgsdoes not use it.Supersedes #569 (which fixed the function) — close #569 without merging. #571 adds an SPDX header to
src/json/parseJson.ts; whichever of the two is merged second needs a one-line conflict resolution (keep the file deleted).Checked: build, 2531/2531 tests, type-check, ESLint (0 errors), Prettier,
docs:check,docs:check-i18n.🤖 Generated with Claude Code