`applyBoundary` on Fields with background set

[ZedThree]

If a Field3D has background set, then the boundary conditions may not be applied correctly, e.g. here:

  if(background != NULL) {
    // Apply boundary to the total of this and background
    
    Field3D tot = *this + (*background);
    tot.applyBoundary(init);
    *this = tot - (*background);
  } else {

tot.bndry_op is empty, so no boundaries get applied. I think this is only important for applyBoundary(bool init) and applyBoundary(BoutReal t). The solution is just to add tot.copyBoundary(*this).

[ZedThree]

Is setting a field background essentially deprecated now? Out of the examples, only the uedge-benchmark actually uses it. I have no idea if it's used out in the wild.

Could it be deprecated entirely and removed in 5.0?

[bendudson]

Yes, this sounds like a good idea. The background field just complicates things, and there is probably a better way to achieve the same thing. Before removing entirely it would be good to find that Better Thing..

…

On 6 January 2017 at 15:27, Peter Hill ***@***.***> wrote: Is setting a field background essentially deprecated now? Out of the examples, only the uedge-benchmark actually uses it. I have no idea if it's used out in the wild. Could it be deprecated entirely and removed in 5.0? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#430 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANYYa-ZkGtd4brZN6gUq4nxMpB5avmvks5rPl1cgaJpZM4Lb6VL> .

[ZedThree]

We deprecated setBackground and removed it entirely in #1326. We don't have a replacement yet -- do we need one?

If not, we can remove a bunch of code that uses background, if so, we should put it on the roadmap!