Remove more deprecated derivs boundaries - #1331
Merged
Merged
Conversation
ZedThree
previously approved these changes
Nov 20, 2018
* next: (110 commits)
Fix use of abs in fieldgenerators
Fix use of abs in utils.hxx
Fix use of abs in cyclic_reduction
Fix use of abs in imex-bdf2 solver
Fix abs use in slepc solver
Fix use of abs in rkgeneric
Improve some comments; use uniform initialisation more consistently
Use `Options::force` to overwrite options quietly
Default initialise field sizes and Field::bndry* status
Default initialise boundaryIs{Copy,Set} in FieldData
Default initialise some Field3D/2D members
Add move constructor for Field2D
Add swap function for Field2D
Add move constructor for Field3D
Make test-command-args quieter
Add test for clobbering datadir from commandline
Fix:Escaping in makefile
Documentation improvements
Improve documentation
Make sure command line short-options override options file settings
...
ZedThree
approved these changes
Nov 27, 2018
Member
|
Not sure why the push test is failing, I can't reproduce. The PR tests succeeds though, so that should be sufficient. I am a bit worried there's some UB hidden somewhere though, and we've just plastered over it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #1326