New shifted metric 2 - #1460
Closed
johnomotani wants to merge 5 commits into
Closed
New shifted metric 2#1460johnomotani wants to merge 5 commits into
johnomotani wants to merge 5 commits into
Conversation
Useful for knowing where to correct y-periodic-boundary cells of zShift using ShiftAngle.
Similar to ShiftedMetric, but transforms to globally field-aligned coordinates instead of calculating yup/ydown fields.
Copies changes made in #1462 to ShiftedMetric
johnomotani
force-pushed
the
new_shifted_metric2
branch
from
December 17, 2018 15:39
577a921 to
7a73f8c
Compare
Member
|
Should we close #1177 if this replaces it? |
Closed
Contributor
Author
|
This new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of
ParallelTransformfor shifted-metric method, transforming to globally field-aligned coordinates to take y-derivatives.Includes a function to correct twist-shift boundary guard cells of
zShiftby adding/subtractingShiftAngle, so twist-shift does not have to be applied during communications. This could be copied toShiftedMetrictoo. Implementing this function required adding thehasBranchCutUp/Downmethods to Mesh.Currently allows parallel derivatives to be taken by going through the branch that transforms to/from field-aligned coordinates. Next step is to merge #1459 so the user can save a field-aligned field and pass that into parallel derivatives. Finally (possibly) would be to auto-magically cache the field-aligned version of the field somewhere so the user does not have to add extra
Field3Ds to their code.Replaces #1177.