Repository navigation
fix(genkit): record cached and reasoning tokens under canonical metric names - #2813
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Conversation
…c names Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Genkit instrumentation logged
usage.cachedContentTokensandusage.thoughtsTokensascached_tokensandreasoning_tokens. The canonical names used by the other Google instrumentation (and read by Braintrust for cost/usage) areprompt_cached_tokensandcompletion_reasoning_tokens, so Genkit spans lost cache and reasoning usage.Fix:
parseGenkitUsageMetricsnow emitsprompt_cached_tokensandcompletion_reasoning_tokens, matchinggoogle-genai-instrumentation.ts. Changeset added.Test: new case in
genkit-instrumentation.test.tschecks the logged span metrics contain the canonical keys and not the old ones (fails before, passes after).This change was prepared with the assistance of an AI coding agent (Claude); the submitter is responsible for the contribution.