Repository navigation
Run migrations before deploying brainstore and service pods - #128
Merged
Kevin Green (KevinGreen) merged 15 commits intoNov 17, 2026
Merged
Conversation
…lm-migration-job # Conflicts: # braintrust/templates/ai-gateway-deployment.yaml
Kevin Green (KevinGreen)
marked this pull request as ready for review
November 12, 2026 22:13
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d460dc908b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Alexey Soldatchenko (soldatchenko)
requested changes
Nov 13, 2026
Kevin Green (KevinGreen)
requested review from
Yash Kulshrestha (YashdalfTheGray) and
Alexey Soldatchenko (soldatchenko)
November 16, 2026 22:01
Erik Weathers (erikdw)
previously approved these changes
Nov 16, 2026
- Replace the full image override with deploymentOrdering.migrationImageTag. - Build automatic and explicit migration images from api.image.repository. - Validate tag and digest overrides and preserve unchanged Job identity.
Alexey Soldatchenko (soldatchenko)
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order changed workloads as migrations → Brainstore → API pools, AI Gateway, and Loop Runtime.
deploymentOrdering.enabled(defaulttrue) controls the whole sequence; unchanged workloads keep running.api.image.repository, at the newest API pool or Brainstore release. Opaque pins require an explicitmigrationImageTagand stableminimumVersionassertion. The override accepts a tag or digest, not a repository.This gates container startup, not Kubernetes object updates. The removed
api.brainstoreStartupGatesetting is ignored; existing opt-outs must setdeploymentOrdering.enabled=false. See README configuration and lifecycle.Input coverage
v, digest pinsapi.image.repository; preserve digests only from that repository.tag@digest, or@digest; reject repository references and invalid types. Missing/null/empty select automatically; numeric tags remain explicit.Validation
Resolves INF-869.