Repository navigation
Remove obsolete BTQL audit log settings - #129
Open
Aswin Karumbunathan (aswink) wants to merge 2 commits into
Open
Aswin Karumbunathan (aswink) wants to merge 2 commits into
Aswin Karumbunathan (aswink) wants to merge 2 commits into
Conversation
Aswin Karumbunathan (aswink)
marked this pull request as ready for review
November 16, 2026 18:45
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data plane v2.23.0 no longer reads
BTQL_AUDIT_LOGS_STRICT_ORG_IDSorBTQL_AUDIT_LOGS_BEST_EFFORT_ORG_IDS, they are instead default on and configurable in the product. Remove their chart values, ConfigMap injection, validation, and example configuration.Values retained by
helm upgrade --reuse-valuesare ignored, so upgrades stop emitting the obsolete environment variables without rejecting old settings.These settings are ignored across cloud providers and image-tag formats. Image versions and optional-service conditions are unchanged.
Validation:
./test.shpassed (539 chart tests, 33 Python tests, AWS/Google/Azure/minimal rendering, and strict Helm lint). The final API ConfigMap suite passed all 42 tests, including the added empty-string case. The Google Autopilot example rendered successfully. Regression cases failed before the removal and passed afterward.Co-authored by StarfolkAI (@starfolkai)[bot]