Skip to content

Remove obsolete BTQL audit log settings - #129

Open
Aswin Karumbunathan (aswink) wants to merge 2 commits into
mainfrom
aswink/remove-obsolete-btql-audit-log-settings
Open

Aswin Karumbunathan (aswink) wants to merge 2 commits into
mainfrom
aswink/remove-obsolete-btql-audit-log-settings

Conversation

@aswink

@aswink Aswin Karumbunathan (aswink) commented Nov 16, 2026 •

Copy link
Copy Markdown

Data plane v2.23.0 no longer reads BTQL_AUDIT_LOGS_STRICT_ORG_IDS or BTQL_AUDIT_LOGS_BEST_EFFORT_ORG_IDS, they are instead default on and configurable in the product. Remove their chart values, ConfigMap injection, validation, and example configuration.

Values retained by helm upgrade --reuse-values are ignored, so upgrades stop emitting the obsolete environment variables without rejecting old settings.

Input Expected behavior
Missing values Neither environment variable is emitted
Empty lists Neither environment variable is emitted
Empty strings Neither environment variable is emitted
Null values Neither environment variable is emitted
Populated strict list Ignored; neither environment variable is emitted
Populated best-effort list Ignored; neither environment variable is emitted
Both lists populated Ignored without rejecting the upgrade
Malformed retained values Ignored without UUID validation

These settings are ignored across cloud providers and image-tag formats. Image versions and optional-service conditions are unchanged.

Validation: ./test.sh passed (539 chart tests, 33 Python tests, AWS/Google/Azure/minimal rendering, and strict Helm lint). The final API ConfigMap suite passed all 42 tests, including the added empty-string case. The Google Autopilot example rendered successfully. Regression cases failed before the removal and passed afterward.

Co-authored by StarfolkAI (@starfolkai)[bot]

@aswink
Aswin Karumbunathan (aswink) marked this pull request as ready for review November 16, 2026 18:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T18:46:19.958536Z 350a35b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant