Skip to content

Load Loop client TLS from Secret Manager - #131

Open
Alex R (alexr17) wants to merge 3 commits into
mainfrom
alexr/loop-public-setup
Open

Alex R (alexr17) wants to merge 3 commits into
mainfrom
alexr/loop-public-setup

Conversation

@alexr17

@alexr17 Alex R (alexr17) commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Loop needs to consume automatically generated TLS without copying private keys into Helm values.
Load a Secret Manager client bundle through Workload Identity in an init container and mount it from memory.
The infrastructure bootstrap installs workers and retains TLS; Terraform app users and direct Helm users consume the same reference.
An omitted or empty reference retains the existing Kubernetes Secret path.

Input Behavior
Google, Loop enabled, Secret Manager version reference Load the client bundle into memory through Workload Identity; runtime mounts it read-only.
Named or numeric project; latest or numeric secret version Preserve the exact reference in the init container.
Reference missing, null or empty string Retain the external sandbox-client-tls Kubernetes Secret mount.
Reference is zero, boolean, map, list, URL, traversal, missing version or query string Reject during chart rendering.
Loop disabled on Google, AWS or Azure Omit runtime and credential loading.
Loop enabled on AWS or Azure Preserve existing unsupported-cloud validation.
Reused pre-Loop values; missing/null Loop maps and partial overrides Preserve the existing disabled/default merge behavior.
Startup ordering enabled or disabled Preserve migration and Brainstore checks; append TLS initialization after them when enabled.
Release tags with/without v, full/short/numeric SHA, prerelease or custom tag Preserve the image string for both runtime and init container.
Replicas missing/null/empty or zero Preserve default one or explicit zero; credentials load only when Pods start.
Native/external TLS and Loop on/off transitions Switch init container and volume with the Pod template; leave externally managed Secrets untouched.
Secret reference changes; latest contents change A reference change rolls Pods; changed latest contents are loaded on their next startup.

The loader tests cover authenticated requests, file permissions, retries, malformed bundles and restarting after read-only files exist.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T03:36:22.715285Z 7b62f52 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@alexr17 Alex R (alexr17) changed the title Make managed Terraform the default Loop setup Install Loop client TLS from generated values Nov 21, 2026
@alexr17 Alex R (alexr17) changed the title Install Loop client TLS from generated values Load Loop client TLS from Secret Manager Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant