fix(sfcompute): stop sending deprecated InfiniBand field - #146
Draft
masonJamesWheeler wants to merge 1 commit into
Draft
fix(sfcompute): stop sending deprecated InfiniBand field#146masonJamesWheeler wants to merge 1 commit into
masonJamesWheeler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SF Compute now derives InfiniBand passthrough from the authenticated account's effective SKU configuration. The legacy request field is deprecated and ignored, and keeping this client-side writer would leave Brev sending obsolete policy input on every instance create.
Changes
_preview_enable_infinibandfield from the SF Compute request body.This is rollout-safe with current and new SF Compute servers: omission already defaults to false, and the compatibility API continues accepting older clients that still send the field.
Testing
make vet fmt-check testgo test ./v1/providers/sfcomputev2