Repository navigation
fix: emit bindings for imported resources without methods - #357
Merged
andreiltd merged 1 commit intoOct 19, 2026
Merged
Conversation
carsonfarmer
requested review from
andreiltd,
tschneidereit and
vados-cosmonic
as code owners
September 26, 2026 22:59
This was referenced Sep 26, 2026
Member
|
Hey @carsonfarmer. Sorry a bit late here. Thanks for the patch, this looks good! It looks like there is an issue where ci builds are picking up incompatible version of bindgen. The fix is here: #358. |
andreiltd
approved these changes
Oct 15, 2026
Contributor
Author
|
Cool! Do you want me to wait for that to merge and rebase this work? |
Member
Yes, that would be great! Thanks! |
Member
|
Hey @carsonfarmer, the fix went in so you can rebase 🙂 |
carsonfarmer
force-pushed
the
cf/opaque-resource-bindings
branch
from
October 16, 2026 17:43
a47770b to
1cec9c8
Compare
Contributor
Author
|
Rebased and pushed :) |
Contributor
Author
|
Hey @andreiltd, it looks like those two windows tests are also failing on main? |
Member
|
Hey @carsonfarmer, indded. Those flaky tests should be now fixed, by #359. |
Seed resource function groups from imported resource types so opaque handles receive the existing class and disposal bindings. Add an ownership, borrowing, and disposal regression.
andreiltd
force-pushed
the
cf/opaque-resource-bindings
branch
from
October 19, 2026 09:33
1cec9c8 to
59aa639
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions returning an imported resource with no methods throw
ReferenceErrorbecause the compiler never generates its class.Generate classes for declared resources, including those without constructors or methods. Add a regression that returns and borrows one, then checks that disposing it calls the host destructor once.
Fixes #221.