Repository navigation
fix: keep constant offset up to date - #35
Merged
cfallin merged 1 commit intoOct 12, 2026
Merged
Conversation
mattermoran
force-pushed
the
fix/constant-offset-deps
branch
from
October 11, 2026 22:17
50b405a to
9bc6f7a
Compare
cfallin
approved these changes
Oct 12, 2026
cfallin
left a comment
Member
There was a problem hiding this comment.
Thanks very much for tracking this down! Yes, indeed, this was an analysis dependency-management bug and the fix looks good.
I'll cut a new release with this fix. I don't control the downstream Fastly SDK anymore so someone else will need to pick up the version bump details as needed there.
Merged
Contributor
Author
|
thank you! once 0.5.1 is out, I can submit a bump pr on fastly side |
Member
|
@mattermoran weval 0.5.1 has now been published to artifacts here, to crates.io, and to NPM (local confirmation after |
This was referenced Oct 12, 2026
gkgoat1
pushed a commit
to gkgoat1/weval
that referenced
this pull request
Oct 13, 2026
- Includes bytecodealliance#35, fixing a bug in the constant-offset optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes an issue where stale analysis results would incorrectly rewrite address calculations
context: after upgrading to fastly js v4 with aot the app would fail during rendering in a preact hook. tracked it down to a bound function receiving a number instead of an object. ok that's weird so digging more led here :)
as you see here when the offset changes the work queue can miss revisiting code that's using it so later it just ends up using the old offset
the test reproduces the issue without needing to run full fastly with preact etc
let me know if you'd like to fix it in a different way but it uses the same pattern already used in
eval.rswith this patch my app happily renders :)