Repository navigation
rust: mark streams done after Dropped(0) - #1755
Merged
Merged
Conversation
alexcrichton
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stream reports that its peer has dropped, subsequent reads or writes should return
StreamResult::Droppedwithout calling the host again.For
Dropped(0), wit-bindgen returns the result without recording that the stream has ended. A later operation therefore callsstream.readorstream.writeagain, which traps because further I/O after a dropped notification is forbidden by the host.This is resolved by settting the reader and writer’s
doneflags when handlingDropped(0).