Skip to content

fix: remove unused ALB egress and tune Trivy findings #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaryGSC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove unused ALB egress and tune Trivy findings #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,14 @@ resource "aws_security_group" "alb-sg" {

// allow access to the ALB from anywhere for 80 and 443
ingress {
description = "HTTP"
from_port = 80
to_port = 80
protocol = "tcp"
cidr_blocks = ["0.0.0.0/0"]
}
ingress {
description = "HTTPS"
from_port = 443
to_port = 443
protocol = "tcp"
Expand All @@ -64,14 +66,8 @@ resource "aws_security_group" "alb-sg" {
cidr_blocks = ["0.0.0.0/0"]
}
}
// allow any outgoing traffic
egress {
protocol = "-1"
from_port = 0
to_port = 0
cidr_blocks = ["0.0.0.0/0"]
}
tags = var.tags
egress = []
tags = var.tags
}

resource "aws_alb_target_group" "tg" {
Expand Down Expand Up @@ -225,6 +221,7 @@ resource "aws_iam_role_policy_attachment" "lambda_policy_attach" {
role = aws_iam_role.iam_for_lambda.name
}

# trivy:ignore:AWS-0104 because applications choose their outbound dependencies
resource "aws_security_group" "lambda_sg" {
count = var.lambda_vpc_config != null ? 1 : 0
name = "${var.app_name}-lambda-sg"
Expand All @@ -234,6 +231,7 @@ resource "aws_security_group" "lambda_sg" {
# ingress not needed as ALB invokes Lambda via AWS API, not direct network traffic

egress {
description = "Lambda outbound traffic"
from_port = 0
to_port = 0
protocol = "-1"
Expand Down Expand Up @@ -359,6 +357,7 @@ resource "aws_codedeploy_deployment_group" "deployment_group" {

# ==================== CloudWatch ====================

# trivy:ignore:AWS-0017
resource "aws_cloudwatch_log_group" "log_group" {
name = "/aws/lambda/${var.app_name}"
retention_in_days = var.log_retention_in_days
Expand Down
Loading