Skip to content

One site header, steadier tabs, and view buttons that only add - #62

Merged
alisman merged 2 commits into
masterfrom
session/page
Oct 23, 2026
Merged

alisman merged 2 commits into
masterfrom
session/page

Conversation

@alisman

@alisman alisman commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

What changes

One header on every page (app/_ui/site-header.tsx)

  • Every page shows the same links in the same order: studies · examples · paper reproductions · hypothesis campaigns · how we verify · rationale.
  • The page you are on is shown as plain text, not a link. Page tools (the "AI tools" menu) and sign-in come after the links.
  • Pages covered: homepage, Results, Comparison, lab, reproductions, verification, rationale, campaigns, groups, data sets.
  • Examples moves from the lab's tab bar to the header. On the lab page the link switches tabs without a reload.
  • The oncoprint-lab and provenance tool pages keep their own headers.

Tabs

  • Unselected tabs are full-strength text. shadcn's default 60% fade made them look disabled.
  • The selected gene sub-tab is a filled teal chip. Every state uses one font weight, so the chips don't shift when you switch.
  • Results/Comparison tabs no longer show a spinner while their view loads. The spinner changed the tab's width.

Loading skeleton on Results / Comparison

  • One skeleton shaped like the page (PortalLoading) replaces the two nested skeletons.
  • The figure skeleton sits as far below its toolbar as the drawing does.

Analysis: view buttons only add

  • Each click adds another view, so a document can hold several views of one kind.
  • A view is removed from its own menu.

Preview

  • / and any page's header
  • /lab?tab=examples
  • /portal/results?study=coadread_tcga_pub&genes=KRAS,NRAS,BRAF&tab=Comparison%2FSurvival

Testing

  • Typecheck, lint and unit tests pass locally (1590).
  • Checked in a browser: the header on every page, Examples opening in place, two Survival views added, and no spinner in the tabs while requests were held.
  • e2e is updated for the moved Examples link, the rationale page's header, and the additive view buttons. The full gate runs on CI.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TyVfAhLnjshk2kWewGnLum

- Every page shares one header (app/_ui/site-header.tsx): the same links in the same order —
  studies, examples, paper reproductions, hypothesis campaigns, how we verify, rationale — the
  current one marked, page tools, then sign-in. Examples moves there from the lab's tab bar.
- Tabs: unselected tabs are full-strength text (shadcn's 60% fade read as disabled); the gene
  sub-tabs' selected state is a filled chip, one font weight in every state so nothing shifts;
  no spinner inside a tab, which changed its width while its view loaded.
- Results / Comparison pages load behind one skeleton shaped like the page (PortalLoading), with
  the figure skeleton spaced under its toolbar as the drawing is.
- Analysis: the add-view buttons always add, so a document can hold several views of one kind;
  a view is removed from its own menu.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TyVfAhLnjshk2kWewGnLum
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cbiolab-genie Ready Ready Preview Oct 23, 2026 2:41pm UTC
cohort-lab Ready Ready Preview Oct 23, 2026 2:41pm UTC

Request Review

@alisman
alisman merged commit c9de71d into master Oct 23, 2026
9 of 10 checks passed
@alisman
alisman deleted the session/page branch October 23, 2026 14:54

This branch was successfully deployed

1 active deployment
Preview – cohort-lab — 4a536176 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant