Repository navigation
Snapshots for the 19 view kinds and options #59 added, in four parallel shards - #63
Merged
Merged
Conversation
…el shards Every view kind now has a snapshot case, and a check fails when one does not: it reads the View union in lib/types.ts, as the documentation tests do, so a new kind cannot land without its case. The 17 new kinds (rmst, acquired, germline, hla, actionability, molsubtype, ctdna, exclusivity, cutpoint, drivernegative, instability, txendpoints, organotropism, multistate, adjusted, predictive, forest) each run their smallest gallery example, and the two new options that change what a view asks (ctdna's chFilter, riskmodel's validateOn) run theirs. All 19 pass the reversed-delivery run unchanged: none of them combines answers in arrival order on its example, so no runner needed askEachSite. Re-recording left every existing snapshot byte for byte as it was: #59 changed no earlier view's queries, numbers, figure or text (its rebase onto #61 had already shown that). With 53 cases, run twice each, the one test file took 71 s and npm test 1 min 45 s. The harness moves to test/support/view-snapshots.ts and the cases run in four test files that node runs in parallel (test/view-snapshots.test.ts, which also runs the every-kind check, and -2/-3/-4), assigned round-robin so the genome-wide cases spread out: 25 s, and npm test 53 s again. Recording runs the four shards in parallel too (the command in CLAUDE.md changes to the glob); each shard records the start-up queries (study routing, profiles) under its own first case, so the answer files of 15 cases moved once, with no output change, and a second recording after that changed nothing. Verified: npm test 1610/1610; three snapshot runs identical; reverting the enrichment fix still fails its case with "depends on the order database answers arrive"; two sharded recordings in a row identical. Size: test/snapshots is now 8.5 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CuBjiBEjYispDSEYDZDWM1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #61 now that #59 is in: every view kind has a snapshot case, and a check fails when one doesn't.
chFilter, riskmodelvalidateOn), each on its smallest gallery example.Viewunion inlib/types.ts(as the documentation tests do); a kind without a case failsnpm test.askEachSite.Speed
53 cases × 2 runs made the single file 71 s and
npm test1 min 45 s. The harness moves totest/support/view-snapshots.ts; cases run in four parallel files (test/view-snapshots.test.ts+-2/-3/-4), round-robin: 25 s, andnpm testback to 53 s. Recording also runs sharded (CLAUDE.md's command is now the glob); after one re-shuffle of where start-up queries are recorded (answer files only, no output change), two sharded recordings in a row are identical.Changes outside tests
Comment-only:
lib/ch.tsandlib/views/shared.tsnow point at the harness's new path. No application behaviour changes.Verification
GATE_PORT=4111 scripts/gate.sh: exit 0 — lint, build, unit 1610/1610, postgres 47/47, access mutants, Python conformance, e2e incl. federation, all warehouse checks. Reverting #61's enrichment fix still fails its case with "depends on the order database answers arrive".test/snapshotsis now 8.5 MB.🤖 Generated with Claude Code
https://claude.ai/code/session_01CuBjiBEjYispDSEYDZDWM1