Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 73 additions & 11 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ harness = false
unsafe_code = "deny"

[dependencies]
blake2 = "0.10"
blake2 = "0.11"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug high

Build break in Cargo.toml: bumping blake2 to 0.11 pulls in digest 0.11, which moves new_from_slice from the Mac trait to KeyInit, but src/keys.rs:11-12 still imports only blake2::digest::Mac while src/keys.rs:173 calls Blake2bMac::<U32>::new_from_slice(&self.0). When the crate builds against 0.11, new_from_slice fails to resolve and compilation stops; if 0.11 also rejects the 32-byte key, the unreachable! at src/keys.rs:174 panics on every value_key call. Fix: import blake2::digest::KeyInit alongside Mac, confirm that cargo build and the key-derivation tests pass with 0.11, or keep the dependency at 0.10.

blake2 = "0.11"
# and in src/keys.rs:
# use blake2::digest::{consts::U32, KeyInit, Mac};
Prompt for LLM

File Cargo.toml:

Line 30:

Build break in Cargo.toml: bumping blake2 to 0.11 pulls in digest 0.11, which moves `new_from_slice` from the `Mac` trait to `KeyInit`, but src/keys.rs:11-12 still imports only `blake2::digest::Mac` while src/keys.rs:173 calls `Blake2bMac::<U32>::new_from_slice(&self.0)`. When the crate builds against 0.11, `new_from_slice` fails to resolve and compilation stops; if 0.11 also rejects the 32-byte key, the `unreachable!` at src/keys.rs:174 panics on every value_key call. Fix: import `blake2::digest::KeyInit` alongside `Mac`, confirm that `cargo build` and the key-derivation tests pass with 0.11, or keep the dependency at 0.10.

Suggested Code:

blake2 = "0.11"
# and in src/keys.rs:
# use blake2::digest::{consts::U32, KeyInit, Mac};

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with πŸ‘ or πŸ‘Ž to help Kody learn from this interaction.

​

​

cachekit-core = { version = "0.6", default-features = false, features = ["encryption"] }
cachekit-rs = { version = "0.9", default-features = false, features = ["cachekitio", "encryption", "file"] }
getrandom = "0.2"
Expand Down
Loading