Skip to content

chore(deps): update rust crate getrandom to 0.4 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cachekit-renovate-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update rust crate getrandom to 0.4 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ unsafe_code = "deny"
blake2 = "0.10"
cachekit-core = { version = "0.6", default-features = false, features = ["encryption"] }
cachekit-rs = { version = "0.9", default-features = false, features = ["cachekitio", "encryption", "file"] }
getrandom = "0.2"
getrandom = "0.4"

@kodus-27b kodus-27b Bot Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kody code-review Bug high

Build break in Cargo.toml: bumping getrandom to 0.4 leaves src/keys.rs:115 calling getrandom::getrandom(&mut secret), which was renamed to getrandom::fill in 0.3 and no longer exists in 0.4. Running cargo build fails with an unresolved function error in create_file_key, so the ck binary cannot be built. Fix: in src/keys.rs, change the call to getrandom::fill(&mut secret), which returns the same Result<(), getrandom::Error>.

getrandom = "0.4"
# and in src/keys.rs:
#     getrandom::fill(&mut secret)
#         .map_err(|e| Fatal(format!("cannot generate a file key: {e}")))?;
Prompt for LLM 

File Cargo.toml:

Line 33:

Build break in Cargo.toml: bumping getrandom to 0.4 leaves src/keys.rs:115 calling `getrandom::getrandom(&mut secret)`, which was renamed to `getrandom::fill` in 0.3 and no longer exists in 0.4. Running `cargo build` fails with an unresolved function error in create_file_key, so the `ck` binary cannot be built. Fix: in src/keys.rs, change the call to `getrandom::fill(&mut secret)`, which returns the same `Result<(), getrandom::Error>`.

Suggested Code:

getrandom = "0.4"
# and in src/keys.rs:
#     getrandom::fill(&mut secret)
#         .map_err(|e| Fatal(format!("cannot generate a file key: {e}")))?;

Talk to Kody by mentioning @kody

Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.

​

​

hex = "0.4"
libc = "0.2"
rustix = { version = "1", default-features = false, features = ["std", "fs", "process"] }
Expand Down
Loading