Skip to content

test(cachekitio): drop the dead walks guard in the interrupt frame test (LAB-8742) - #571

Merged
27b-merge-warden[bot] merged 1 commit into
mainfrom
lab-8742-drop-dead-walks-guard
Oct 10, 2026
Merged

27b-merge-warden[bot] merged 1 commit into
mainfrom
lab-8742-drop-dead-walks-guard

Conversation

@27Bslash6

Copy link
Copy Markdown
Contributor

The interrupt branch in CachekitIOBackend._send now calls the shared _clear_interrupted, which walks the chain through cachekit.backends._uninterrupted._raised_during_request directly. Patching backend_module._raised_during_request therefore only reaches the transport handler's walk, so the len(walks) == 1 guard in test_interrupt_while_dropping_a_transport_failures_tracebacks_holds_no_exception was always true. This removes the walks list and the guard, makes the patched walk yield the first exception and then raise KeyboardInterrupt, and documents in the docstring that only the transport handler's walk is patched.

It also fixes two stale test comments: the keyring test no longer claims the sync wrapper lacks an outer finally, and the context-leak fixture docstring reads "without it, one leaking test would also fail".

Test-only change; no behaviour change. A mutation check on _send's interrupt branch gives the same result before and after the edit: deleting the _clear_interrupted(...) call survives in both, and deleting raised = error = None fails _cachekit_frames_holding_an_exception(exc) == [] in both.

Closes LAB-8742

The interrupt branch now walks through the shared module's own
_raised_during_request, so patching the backend module's name only
reaches the transport handler's walk and the len(walks) guard was
always true. Also corrects two stale test comments.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: cachekit-io/cachekit-py/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 54accca7-a9b0-4bce-81f9-aa7bb939331e

📥 Commits

Reviewing files that changed from the base of the PR and between 29c6a59 and bad5f9b.


📒 Files selected for processing (3)
  • tests/unit/backends/test_cachekitio_transport_error_frames.py
  • tests/unit/test_context_leak_regression.py
  • tests/unit/test_key_rotation_keyring.py

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kodus-27b

kodus-27b Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@27b-merge-warden
27b-merge-warden Bot merged commit 591b656 into main Oct 10, 2026
37 checks passed
@27b-merge-warden
27b-merge-warden Bot deleted the lab-8742-drop-dead-walks-guard branch October 10, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant