Skip to content

fix(conformance): interop cross-check self-tests require the expected rejection class (LAB-8795) #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
27b-merge-warden merged 1 commit into from
Oct 10, 2026
Merged

fix(conformance): interop cross-check self-tests require the expected rejection class (LAB-8795) #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions tools/interop-crosscheck.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,9 @@ function encodeCanonical(v, chunks, { collapseFloats }) {
// outside the data model and falls through to the error below, never to an
// empty map. Sort keys by UTF-8 byte order (== Unicode code point order). JS default
// string sort compares UTF-16 code units and gets supplementary-plane
// characters WRONG — compare encoded bytes instead. Its data is its own
// enumerable properties, and an enumerable Symbol key is a non-string map key.
// characters WRONG — compare encoded bytes instead.
// A plain object's data is its own enumerable properties, and an enumerable
// Symbol key is a non-string map key.
// propertyIsEnumerable goes through Object.prototype: a null-prototype object
// has none, and the message names no Symbol, since interpolating one throws.
if (Object.getOwnPropertySymbols(v).some((s) => Object.prototype.propertyIsEnumerable.call(v, s))) {
Expand Down Expand Up @@ -542,12 +543,17 @@ for (const v of doc.error_vectors) {

// Self-tests for inputs portable JSON cannot carry. Named functions, so
// conformance/requirements.json can cite them.
function expectRejected(test, label, args) {
// The rejection must be exactly errorClass: OutOfModelError extends Error, so
// instanceof could not tell a plain Error from it.
function expectRejected(test, label, args, errorClass) {
try {
encodeToBuffer(args, { collapseFloats: true });
} catch (err) {
if (err instanceof TypeError || err instanceof ReferenceError) throw err; // a harness bug, not a rejection
return; // expected
if (err.constructor === errorClass) return; // expected
failures++;
console.error(`FAIL ${test} (${label}): expected ${errorClass.name}, got ${err.constructor.name}: ${err.message}`);
return;
}
failures++;
console.error(`FAIL ${test} (${label}): expected rejection, encoding succeeded`);
Expand All @@ -566,7 +572,7 @@ function loneSurrogateSelftest() {
["lone surrogate in a nested value", [{ k: ["ok", lo] }]],
["lone surrogate in a set", [new TaggedSet([hi])]],
]) {
expectRejected("loneSurrogateSelftest", label, args);
expectRejected("loneSurrogateSelftest", label, args, Error);
}
check("loneSurrogateSelftest", "valid pair", "91a4f0908080", encodeToBuffer([hi + lo], { collapseFloats: true }).toString("hex"));
}
Expand All @@ -584,7 +590,7 @@ function outOfModelSelftest() {
["class instance in a map value", [{ k: new Point() }]],
["class instance in a set", [new TaggedSet([new Point()])]],
]) {
expectRejected("outOfModelSelftest", label, args);
expectRejected("outOfModelSelftest", label, args, OutOfModelError);
}
}

Expand All @@ -601,7 +607,7 @@ function nonStringKeySelftest() {
["Symbol key in a list", [[1n, { [sym]: 1n }]]],
["Symbol key in a set element", [new TaggedSet([{ [sym]: 1n }])]],
]) {
expectRejected("nonStringKeySelftest", label, args);
expectRejected("nonStringKeySelftest", label, args, OutOfModelError);
}
const hidden = Object.defineProperty({ a: 2n }, sym, { value: 1n, enumerable: false });
check("nonStringKeySelftest", "non-enumerable Symbol key", "9181a16102", encodeToBuffer([hidden], { collapseFloats: true }).toString("hex"));
Expand All @@ -619,7 +625,7 @@ function unsafeNumberSelftest() {
["2^53 + 2 in a list", [[2 ** 53 + 2]]],
["2^53 + 2 in a map value", [{ id: 2 ** 53 + 2 }]],
]) {
expectRejected("unsafeNumberSelftest", label, args);
expectRejected("unsafeNumberSelftest", label, args, Error);
}
const safe = Number.MAX_SAFE_INTEGER;
check(
Expand Down
Loading