Skip to content

Streamline status page tests #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbrooksuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Streamline status page tests #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions tests/Feature/Http/Controllers/Subscribers/SubscribeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

it('shows the subscribe page', function () {
get(route('cachet.subscribers.create'))
->assertOk()
->assertSee(__('cachet::subscriber.status_page.subscribe.heading'))
->assertSee('data-page="subscribe"', escape: false)
->assertSee('data-component="subscribe"', escape: false);
Expand Down Expand Up @@ -181,7 +180,6 @@
$subscriber = Subscriber::factory()->verified()->create();

get($subscriber->unsubscribeUrl())
->assertOk()
->assertSee(__('cachet::subscriber.status_page.unsubscribe.heading'))
->assertSee($subscriber->email)
->assertSee('data-page="unsubscribe"', escape: false)
Expand All @@ -192,16 +190,15 @@

it('renders unsubscribe hooks around the confirmation', function () {
$subscriber = Subscriber::factory()->verified()->create();
CachetView::registerRenderHook(RenderHook::STATUS_PAGE_UNSUBSCRIBE_BEFORE, fn () => '<span>unsubscribe-before-hook</span>');
CachetView::registerRenderHook(RenderHook::STATUS_PAGE_UNSUBSCRIBE_AFTER, fn () => '<span>unsubscribe-after-hook</span>');
CachetView::registerRenderHook(RenderHook::STATUS_PAGE_UNSUBSCRIBE_BEFORE, fn () => 'unsubscribe-before-hook');
CachetView::registerRenderHook(RenderHook::STATUS_PAGE_UNSUBSCRIBE_AFTER, fn () => 'unsubscribe-after-hook');

get($subscriber->unsubscribeUrl())
->assertOk()
->assertSeeInOrder([
->assertSeeTextInOrder([
'unsubscribe-before-hook',
'data-slot="content"',
__('cachet::subscriber.status_page.unsubscribe.heading'),
'unsubscribe-after-hook',
], escape: false);
]);
});

it('unsubscribes a subscriber once confirmed', function () {
Expand Down
56 changes: 18 additions & 38 deletions tests/Feature/StatusPage/IncidentPageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,30 @@
use Cachet\Models\Component;
use Cachet\Models\Incident;

it('shows the affected components on the incident page', function () {
it('renders incident details with stable theme selectors', function () {
$component = Component::factory()->create(['name' => 'API']);
$incident = Incident::factory()->create();
$incident = Incident::factory()->create(['name' => 'API connectivity']);
$incident->components()->attach($component, [
'component_status' => ComponentStatusEnum::performance_issues->value,
]);

$this->get(route('cachet.status-page.incident', $incident))
->assertOk()
->assertSeeText('API connectivity')
->assertSee(__('cachet::incident.affected_components_header'))
Comment on lines 14 to 16

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve detail-page heading semantics

When an incident or schedule name remains visible but is changed from an <h1> to a non-heading element, these consolidated text assertions still pass. The previous incident and schedule tests explicitly protected the pages' primary-heading semantics, and no replacement assertion checks them; keep a DOM-level <h1> assertion for both detail pages.

Useful? React with 👍 / 👎.

->assertSee('API');
->assertSee('API')
->assertSee([
'data-page="incident"',
'data-component="affected-components"',
'data-component="incident"',
'data-component="incident-update"',
'data-component="incident-update-status"',
'data-component="badge"',
'data-component="timestamp"',
'data-component="page-navigation"',
'data-slot="main"',
'data-slot="indicator"',
'data-slot="message"',
], escape: false);
});

it('does not show the affected components box when none are attached', function () {
Expand All @@ -31,39 +44,6 @@
]);

$this->get(route('cachet.status-page.incident', $incident))
->assertOk()
->assertSee('<strong>investigating</strong>', escape: false)
->assertSeeText('investigating')
->assertDontSee('<script>alert(1)</script>', escape: false);
});

it('uses the incident name as the page heading', function () {
$incident = Incident::factory()->create(['name' => 'API connectivity']);

$page = $this->get(route('cachet.status-page.incident', $incident))
->assertOk()
->getContent();

expect($page)->toMatch('/<h1[^>]*>\s*API connectivity\s*<\/h1>/');
});

it('renders stable incident page attributes', function () {
$component = Component::factory()->create();
$incident = Incident::factory()->create();
$incident->components()->attach($component, [
'component_status' => ComponentStatusEnum::performance_issues->value,
]);

$this->get(route('cachet.status-page.incident', $incident))
->assertOk()
->assertSee('data-page="incident"', escape: false)
->assertSee('data-component="affected-components"', escape: false)
->assertSee('data-component="incident"', escape: false)
->assertSee('data-component="incident-update"', escape: false)
->assertSee('data-component="incident-update-status"', escape: false)
->assertSee('data-component="badge"', escape: false)
->assertSee('data-component="timestamp"', escape: false)
->assertSee('data-component="page-navigation"', escape: false)
->assertSee('data-slot="main"', escape: false)
->assertSee('data-slot="indicator"', escape: false)
->assertSee('data-slot="message"', escape: false);
});
44 changes: 12 additions & 32 deletions tests/Feature/StatusPage/SchedulePageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

use function Pest\Laravel\get;

it('renders the schedule page', function () {
it('renders schedule details with stable theme selectors', function () {
$schedule = Schedule::factory()->create([
'name' => 'Database maintenance',
'message' => 'We will be upgrading the database.',
Expand All @@ -22,9 +22,18 @@
$schedule->updates()->save($update);

get(route('cachet.status-page.schedule', ['schedule' => $schedule]))
->assertOk()
->assertSee('Database maintenance')
->assertSee('Maintenance window confirmed.');
->assertSee('Maintenance window confirmed.')
->assertSee([
'data-page="schedule"',
'data-component="schedule"',
'data-component="schedule-update"',
'data-component="badge"',
'data-component="timestamp"',
'data-component="page-navigation"',
'data-slot="main"',
'data-slot="message"',
], escape: false);
});

it('links to schedules from the status page', function () {
Expand All @@ -38,32 +47,3 @@
it('returns not found for a missing schedule', function () {
get(route('cachet.status-page.schedule', ['schedule' => 999]))->assertNotFound();
});

it('uses the maintenance name as the page heading', function () {
$schedule = Schedule::factory()->create(['name' => 'Database maintenance']);

$page = get(route('cachet.status-page.schedule', ['schedule' => $schedule]))
->assertOk()
->getContent();

expect($page)->toMatch('/<h1[^>]*>\s*Database maintenance\s*<\/h1>/');
});

it('renders stable maintenance page attributes', function () {
$schedule = Schedule::factory()->create();
$schedule->updates()->save(new Update([
'message' => 'Maintenance is underway.',
'status' => IncidentStatusEnum::unknown,
]));

get(route('cachet.status-page.schedule', ['schedule' => $schedule]))
->assertOk()
->assertSee('data-page="schedule"', escape: false)
->assertSee('data-component="schedule"', escape: false)
->assertSee('data-component="schedule-update"', escape: false)
->assertSee('data-component="badge"', escape: false)
->assertSee('data-component="timestamp"', escape: false)
->assertSee('data-component="page-navigation"', escape: false)
->assertSee('data-slot="main"', escape: false)
->assertSee('data-slot="message"', escape: false);
});
Loading
Loading