Repository navigation
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Size Report
Startup median (7 runs, lower is better):
|
f9260b1 to
22fb210
Compare
|
I reviewed 22fb210 and found no problems in the code. The manual Android replay job now keeps the suite timing, and the script keeps the real exit status after it prints both timings. The test uses distinct serials, so a hardcoded serial would fail. All 22 checks pass, and there are no conflicts. Nothing else blocks merge. The earlier hosted manual Android run reproduced the timings, but I did not run the vitest case or the failure path on the hosted emulator, so exit-code preservation rests on the stubbed test and reading the code. Both inline threads from cubic-dev-ai are fixed at this commit, so you can resolve them: #3554 (comment) (the test now uses emulator-7000 and emulator-8100, and the adb stub rejects a mismatch) and #3554 (comment) (the script saves the status with Two small, optional notes. The stubbed |
22fb210 to
a85a0f0
Compare
|
Thanks for the update. The Android serial and exit-code handling from the earlier pass (22fb210) are now fixed at a85a0f0, and I found nothing new in the code. The two inline threads on the distinct emulator serials and on keeping the full-suite exit status both look fixed at this head, so you can resolve them: #3554 (comment) and #3554 (comment). I judged the stubbed test from the diff and the script. I did not run the vitest case or the hosted emulator path. I also did not open hosted run 38324090019, so I have not confirmed that the emulator action exports ANDROID_SERIAL to the script. The exit-code behavior on a real emulator rests on the stubbed test and on reading the code. I did not review the 122-file rebase delta, since it is upstream content. No conflicts. The two Smoke Tests runs and Mutants (snapshot-occlusion) are still pending, not failed. This patch only touches the manual workflow, the Android manual script and its test, and a vitest exclusion, so those jobs can only be affected by the rebased-in base changes. Merge once those jobs finish green. |
Summary
The pinned emulator action starts a separate shell for each script line, losing Android setup/full-suite timestamps and reporting negative setup and zero suite durations.
Run the existing pipeline through one shell using the action's emulator serial. Record both timings even if full E2E fails, then preserve its exit code and stop before ordinary replay. Four files changed; prerequisite for #3555 and #3077 validation.
Validation
Tested head:
a85a0f09b7916c7627a50aa94cc34ce82da4a0d0.8255c735: FAIL (-90s/0s)f9260b1ee: 1 FAIL / 2 PASSThree focused cases cover two independent serials; hardcoding the first serial fails both other-serial cases. Mutation restored. Repository format, shell syntax and fresh review pass. Rebased onto main
a95d2d539without changing either implementation commit. Exact-headpnpm check:affected --base a95d2d539 --runpasses all runnable gates; current heada85a0f09bhas 21 successful checks and one expected cache skip, including Coverage/Integration and all four platform smoke suites. No unresolved review threads; no merge conflicts.Earlier hosted Android on runtime head
a3aba45areports setup 92s/full 398s. Its success evidence is retained; the failure-path extension is covered independently. Pure workflow repair; no new device behavior.