Repository navigation
docs(contracts): scope the iOS keyboard class claim to instantiation - #3572
Conversation
The IOS_KEYBOARD_* docblock said the classes are "private to the keyboard surfaces — an app cannot host one in its own view tree", while the marker bullet below it describes hosts the app CAN fill. Limit the sentence to what is true of the classes themselves (an app cannot instantiate them) and leave the subtree question to the per-table bullets, which already answer it. Follow-up to #3482's final review note; no behavior change.
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 4d7d0c8. The change only edits a comment in one contracts file, so it cannot change runtime behavior. Not blocking: the claim "cannot instantiate" at https://github.com/callstack/agent-device/blob/4d7d0c8/packages/contracts/src/android-input-ownership.ts#L157 holds only for public API, so you could say "cannot instantiate them through public API"; take it or leave it. I did not check the iOS SDK to confirm that no public initializer exists for these private classes. CI is still pending. All 15 non-passing checks are queued, none have failed. Once they run, the PR can merge. |
|
One observation for whoever next touches this preflight, stated as an observation, not a fix: with If the rerun comes back with |
|
Updating this because my previous note set a standard and the rerun met it: I wrote that if the rerun came back Attempt 2 failed a different, dispatched step. Not preflight: The capture immediately before it — What this is not: caused by this diff. What I am not claiming: that the lane is wrong to fail. So I stopped rerunning. Two attempts on a comment-only change is already pool time I would rather spend on #3522 and #3570, and a third would be collecting flake statistics rather than fixing anything. Your options, in the order I'd take them: rerun this lane when the pool is quieter (the content is proven), merge it as-is on the ground that the diff has no executable change to certify, or close it — the sentence is worth having, but not at the cost of the queue. Nothing here is a blocker for #3522, which is green and mergeable, or for #3570. |
|
Reran the failed job as the owner's call accepts — attempt 3 is queued on Taking the nit's wording as offered but not pushing for it: a push would restart all lanes, including the smoke job now rerunning, for two words in a docblock. If the sentence should read |
Follow-up to #3482's final review note (#3482 (comment), "not blocking").
The
IOS_KEYBOARD_*docblock claimed the classes are "private to the keyboard surfaces — an app cannot host one in its own view tree". That overclaims: the fourth bullet below it (IOS_KEYBOARD_CHROME_MARKER_ROLES) describes hosts the app can fill — its custominputView, itsinputAssistantItembar buttons riding the assistant view. The sentence is now limited to what is true of the classes themselves — an app cannot instantiate them — and the subtree question is left to the per-table bullets, which already answer it correctly (the subtree table says "an app can never fill these"; the marker table says the opposite and claims no subtree).Two lines of prose in a docblock. No code, no behavior change, so no test or device evidence applies: the classification the bullets describe is pinned by the
snapshot-chromefixtures and the breakdown case added in #3482, neither of which is touched here.Validation
pnpm check:affected --run --base origin/mainat4d7d0c807: all runnable checks passed (exit 0) — 565 related test files / 4,323 tests, Fallow clean on the 1 changed file — held under the machine-wide lock, started2026-10-13T11:03:41Z.format,lint,tsc -b,check:layeringandbuildpass.