Repository navigation
refactor(move): name the agent-device client tests for their module - #3649
Conversation
Size Report
Startup median (7 runs, lower is better):
|
…pure git mv) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eadce9a to
1cf5ba0
Compare
|
I reviewed eadce9a and found no problems. The change only renames the client test files to match their modules, and a head grep found no references to the old names. Coverage fails only in eager-closure-budgets, on the stale APPROVED_OVER_CEILING row for packages/daemon/src/index.ts. This PR touches no production closure, and #3650 fails the same way at the same merge-base, so the failure looks unrelated. I did not run the tests, read the Smoke Tests log, or check the baseline files for the old paths. There are no conflicts, and nothing in this PR blocks merge. |
|
Clean on 1cf5ba0. The diff is test renames plus one comment, so the production closure does not change. I did not run the renamed tests. The Compatibility & Provenance check was still running when I looked, and I did not read its log. The author reports the eager-closure-budgets failure on a stale daemon index row also reproduces on #3650 at the same merge-base, which I did not check myself. There are no conflicts. Wait for Compatibility & Provenance to finish before merging. |
|
Summary
Class r: eleven tests in
src/__tests__namedclient-*all exercisesrc/agent-device-client.ts, so they now carry its name (<module>-<aspect>):client.test.ts→agent-device-client.test.ts,client-wait→agent-device-client-wait, and so on for abort-signal, apps, interactions-input-filtering, leases, snapshot-{keyboard-fact,presented-surface,truncation,viewport}, system-commands.The renames are one
git mvcommit, 100% similarity, zero content lines (git diff -M --summary: 11 renames). The second commit edits one comment that named the old file. They stay insrc/__tests__, the parent's__tests__ofsrc/agent-device-client.ts, next toagent-device-client-auth.test.ts. Noexports, fixture or barrel change. Seeds no colocation baseline entry yet (rule not on main).Validation
Head
eadce9acf:check:quick,check:layering,check:fallow,check:gate-manifest,check:affected --run,pnpm formatall pass.vitest run <files> --reporter=json): client 40, abort-signal 4, apps 9, interactions-input-filtering 2, leases 1, snapshot-keyboard-fact 5, -presented-surface 7, -truncation 1, -viewport 3, system-commands 8, wait 1.unit-core(src/**/*.test.ts); renames stay in the same directory.vi.mock: none of these files uses it..tmp/orphans.mjs) on this branch: 99 → 88.🤖 Generated with Claude Code