Skip to content

refactor(move): name the agent-device client tests for their module - #3649

Merged
thymikee merged 2 commits into
mainfrom
refactor/colocate-root-agent-device-client
Oct 15, 2026
Merged

thymikee merged 2 commits into
mainfrom
refactor/colocate-root-agent-device-client

Conversation

@thymikee

@thymikee thymikee commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Class r: eleven tests in src/__tests__ named client-* all exercise src/agent-device-client.ts, so they now carry its name (<module>-<aspect>): client.test.ts → agent-device-client.test.ts, client-wait → agent-device-client-wait, and so on for abort-signal, apps, interactions-input-filtering, leases, snapshot-{keyboard-fact,presented-surface,truncation,viewport}, system-commands.

The renames are one git mv commit, 100% similarity, zero content lines (git diff -M --summary: 11 renames). The second commit edits one comment that named the old file. They stay in src/__tests__, the parent's __tests__ of src/agent-device-client.ts, next to agent-device-client-auth.test.ts. No exports, fixture or barrel change. Seeds no colocation baseline entry yet (rule not on main).

Validation

Head eadce9acf: check:quick, check:layering, check:fallow, check:gate-manifest, check:affected --run, pnpm format all pass.

  • Parity: 81 tests before, 81 after, per file identical (vitest run <files> --reporter=json): client 40, abort-signal 4, apps 9, interactions-input-filtering 2, leases 1, snapshot-keyboard-fact 5, -presented-surface 7, -truncation 1, -viewport 3, system-commands 8, wait 1.
  • Selection: all run in unit-core (src/**/*.test.ts); renames stay in the same directory.
  • vi.mock: none of these files uses it.
  • Orphan count (.tmp/orphans.mjs) on this branch: 99 → 88.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.25 MB 5.25 MB 0 B
Package (unpacked) 5.25 MB 5.25 MB 0 B
Package (download) 1.58 MB 1.58 MB +6 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.0 ms 26.3 ms +0.3 ms
CLI --help 75.0 ms 77.7 ms +2.7 ms

thymikee and others added 2 commits October 15, 2026 14:34
…pure git mv)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thymikee
thymikee force-pushed the refactor/colocate-root-agent-device-client branch from eadce9a to 1cf5ba0 Compare October 15, 2026 12:34
@thymikee

Copy link
Copy Markdown
Member Author

I reviewed eadce9a and found no problems. The change only renames the client test files to match their modules, and a head grep found no references to the old names. Coverage fails only in eager-closure-budgets, on the stale APPROVED_OVER_CEILING row for packages/daemon/src/index.ts. This PR touches no production closure, and #3650 fails the same way at the same merge-base, so the failure looks unrelated. I did not run the tests, read the Smoke Tests log, or check the baseline files for the old paths. There are no conflicts, and nothing in this PR blocks merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 15, 2026
@thymikee
thymikee merged commit aabc98b into main Oct 15, 2026
18 checks passed
@thymikee
thymikee deleted the refactor/colocate-root-agent-device-client branch October 15, 2026 13:36
@thymikee

Copy link
Copy Markdown
Member Author

Clean on 1cf5ba0. The diff is test renames plus one comment, so the production closure does not change. I did not run the renamed tests. The Compatibility & Provenance check was still running when I looked, and I did not read its log. The author reports the eager-closure-budgets failure on a stale daemon index row also reproduces on #3650 at the same merge-base, which I did not check myself. There are no conflicts. Wait for Compatibility & Provenance to finish before merging.

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-15 14:26 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant