Skip to content

refactor(replay): move four daemon tests of replay-port code into replay-port #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 3 commits into from
Oct 15, 2026
Merged

refactor(replay): move four daemon tests of replay-port code into replay-port #3650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dc3dac
refactor(replay): move four daemon tests of replay-port code beside t…
thymikee Oct 15, 2026
23c6169
refactor(replay): import the moved tests relatively
thymikee Oct 15, 2026
d9f07bd
chore(gates): drop the replay-port session-test-source-discovery export
thymikee Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/replay-port/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,6 @@
"types": "./src/daemon-port/session-test-shard-devices.ts",
"default": "./src/daemon-port/session-test-shard-devices.ts"
},
"./session-test-source-discovery": {
"types": "./src/daemon-port/session-test-source-discovery.ts",
"default": "./src/daemon-port/session-test-source-discovery.ts"
},
"./target-classification": {
"types": "./src/daemon-port/target-classification.ts",
"default": "./src/daemon-port/target-classification.ts"
Expand Down
6 changes: 3 additions & 3 deletions ...ite/session-test-source-discovery.test.ts → ...-test-source-discovery-inspection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ import { test } from 'vitest';
import assert from 'node:assert/strict';
import fs from 'node:fs';
import path from 'node:path';
import { buildReplayTestSourceDiscovery } from '@agent-device/replay-port/session-test-source-discovery';
import { mkdtempForTestSync } from '@agent-device/test-kit/tmp-dir';
import { buildReplayTestSourceDiscovery } from '../session-test-source-discovery.ts';
import { mkdtempForTestSync } from '../../tmp-dir.fixtures.ts';
import {
maestroScriptSourceBundleFor,
replayScriptSourceBundleFor,
} from '@agent-device/replay-port/replay-script-source-fixtures';
} from '../../replay-script-source.fixtures.ts';

// #1478 P3b: the daemon adapter's inspection capability. #1802 moved expansion and file reading
// to the caller, so what is left here is exactly format routing plus per-engine manifest
Expand Down
2 changes: 1 addition & 1 deletion ...n-test-suite-command-cancellation.test.ts → ...tests__/test-command-cancellation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
markRequestCanceled,
registerRequestAbort,
} from '@agent-device/host-kit/request';
import { bindReplayTestAttemptCancellation } from '@agent-device/replay-port/test-command';
import { bindReplayTestAttemptCancellation } from '../test-command.ts';

// The daemon half of the replay-test cancellation seam (#1478 P3b). The scheduler only says
// "cancel" and "release"; everything here — registry entries, the parent-abort relay, and
Expand Down
2 changes: 1 addition & 1 deletion ...n-test-suite-command-nested-flags.test.ts → ...tests__/test-command-nested-flags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
import assert from 'node:assert/strict';
import { test } from 'vitest';
import { buildNestedReplayFlags } from '@agent-device/replay-port/test-command';
import { buildNestedReplayFlags } from '../test-command.ts';

test('buildNestedReplayFlags returns parent flags untouched when neither override is set', () => {
const parent = { platform: 'android' as const, timeoutMs: 5000 };
Expand Down
8 changes: 4 additions & 4 deletions ...st-suite-command-remote-artifacts.test.ts → ...s__/test-command-remote-artifacts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ import fs from 'node:fs';
import path from 'node:path';
import { test } from 'vitest';
import type { ReplaySuiteResult } from '@agent-device/contracts/replay';
import type { DaemonRequest } from '../../../core/daemon-request.ts';
import { attachRemoteReplayTestArtifacts } from '@agent-device/replay-port/test-command';
import { mkdtempForTestSync } from '@agent-device/test-kit/tmp-dir';
import type { DaemonWireRequest } from '@agent-device/contracts/command';
import { attachRemoteReplayTestArtifacts } from '../test-command.ts';
import { mkdtempForTestSync } from '../../tmp-dir.fixtures.ts';

const SUITE_INVOCATION_ID = 'cd5f9c01feec8d70';

Expand Down Expand Up @@ -73,7 +73,7 @@ function suiteResult(daemonRoot: string): ReplaySuiteResult {
};
}

function req(clientArtifactsRoot: string | undefined): DaemonRequest {
function req(clientArtifactsRoot: string | undefined): DaemonWireRequest {
return {
token: 't',
session: 'default',
Expand Down
Loading