Skip to content

test(host-kit): stub os.homedir for the exec-trace late-close test #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Oct 22, 2026
+4 −2
Merged

test(host-kit): stub os.homedir for the exec-trace late-close test #3898

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
495cd8d
test(host-kit): stub os.homedir for the exec-trace late-close test
thymikee Oct 22, 2026
a7db258
Merge branch 'main' into fix/exec-trace-test-under-stryker
thymikee Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/host-kit/src/internal/exec-trace.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { ChildProcess, spawn } from 'node:child_process';
import fs from 'node:fs';
// oxlint-disable-next-line no-restricted-imports -- vi.spyOn(os,'homedir'): os.homedir() ignores a stubbed HOME in worker threads
import os from 'node:os';
import path from 'node:path';
import { PassThrough } from 'node:stream';
import { afterEach, expect, test, vi } from 'vitest';
Expand Down Expand Up @@ -199,7 +201,7 @@ for (const fixedLogPath of [true, false]) {
vi.useFakeTimers();
const fixture = processFixture();
const home = mkdtempForTestSync('exec-late-close-');
vi.stubEnv('HOME', home);
const homedir = vi.spyOn(os, 'homedir').mockReturnValue(home);
const logPath = fixedLogPath ? path.join(home, 'request.ndjson') : undefined;
try {
await withCommandHost(
Expand Down Expand Up @@ -242,7 +244,7 @@ for (const fixedLogPath of [true, false]) {
}),
);
} finally {
vi.unstubAllEnvs();
homedir.mockRestore();
}
});
}
Expand Down
Loading