Repository navigation
Conversation
edec660 to
9903011
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The Android NDK pin is incompatible with RN 0.88’s 16 KiB page-size configuration, and the documentation overstates stable-version support.
2 open findings
What changed in this PR
Upgrades the project and example app to React Native 0.88 RC and adopts the iOS scene lifecycle.
Changes:
- Updates React Native, React, presets, and example dependencies.
- Migrates iOS startup to
SceneDelegate. - Regenerates JavaScript and CocoaPods lockfiles.
| File | Description |
|---|---|
README.md |
Updates supported RN versions. |
package.json |
Upgrades core development dependencies. |
example/package.json |
Upgrades example app dependencies. |
example/ios/Podfile.lock |
Locks updated iOS pods. |
example/ios/PagerViewExample/SceneDelegate.swift |
Initializes React Native through scenes. |
example/ios/PagerViewExample/Info.plist |
Registers the scene lifecycle. |
example/ios/PagerViewExample/AppDelegate.swift |
Removes legacy RN initialization. |
example/ios/PagerViewExample.xcodeproj/project.pbxproj |
Adds SceneDelegate to the target. |
bun.lock |
Locks upgraded JavaScript dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "react": "19.2.3", | ||
| "react-native": "0.87.1", | ||
| "react": "19.3.0", | ||
| "react-native": "0.88.0-rc.5", |
🟢 e2e: 14 passedAll 14 tests in 10 files
e2e 0.18.0 · 3m 32s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 6m 30s · ios · run artifacts |
7b61f49 to
339d414
Compare
🟢 e2e: 20 passedAll 20 tests in 12 files
e2e 0.21.0 · 5m 16s · android · run artifacts |
🟢 e2e: 1 flaky, 12 passed
|
| Test | Time | |
|---|---|---|
| tests/basic-pager.e2e.ts · 1 flaky, 2 passed | 4m 3s | |
| 🟢 | basic pager › in LTR › pages horizontally | 1m 41s |
| basic pager › in LTR › pages vertically (1 failed attempt first) | 1m 8s | |
| 🟢 | basic pager › in RTL › pages horizontally with the reversed gesture | 1m 13s |
| 🟢 | tests/issues/issue-1083-modal-set-page.e2e.ts · 1 passed | 23.9s |
| 🟢 | setPage called behind a native-stack modal lands on the requested page | 23.9s |
| 🟢 | tests/issues/issue-1096-keyboard-shrink.e2e.ts · 1 passed | 58.1s |
| 🟢 | keyboard avoidance does not shrink the page under the keyboard | 58.1s |
| 🟢 | tests/issues/issue-1098-nested-pager.e2e.ts · 1 passed | 33.5s |
| 🟢 | outer pager stays responsive after its page count changes around a nested pager | 33.5s |
| 🟢 | tests/issues/issue-1142-search-bar-inset.e2e.ts · 1 passed | 21.4s |
| 🟢 | FlatList inside the pager gets the search bar safe-area insets | 21.4s |
| 🟢 | tests/material-top-bar.e2e.ts · 1 passed | 29.5s |
| 🟢 | material top tabs survive a native-stack push and pop | 29.5s |
| 🟢 | tests/nested-pager-view.e2e.ts · 1 passed | 23.5s |
| 🟢 | nested horizontal and vertical pagers scroll independently | 23.5s |
| 🟢 | tests/on-page-selected.e2e.ts · 1 passed | 22.1s |
| 🟢 | onPageSelected fires an alert for every page change | 22.1s |
| 🟢 | tests/scrollable-pager-view.e2e.ts · 1 passed | 31.2s |
| 🟢 | pager inside a ScrollView keeps its page across vertical scrolls | 31.2s |
| 🟢 | tests/smoke.e2e.ts · 1 passed | 13.0s |
| 🟢 | horizontal pager pages with the panel buttons | 13.0s |
| 🟢 | tests/tab-view-inside-scroll-view.e2e.ts · 1 passed | 20.2s |
| 🟢 | TabView inside a ScrollView swipes tabs and scrolls the page | 20.2s |
e2e 0.21.0 · 9m 19s · ios · run artifacts
339d414 to
6dcbcfe
Compare


Summary
Upgrades RN to
v0.88Applies changes from template to use
SceneDelegateinstead ofAppDelegateto support iOS 27Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md