Repository navigation
chore: improve ci required checks - #1174
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Push concurrency uses unique commit SHAs, preventing older main-branch runs from being cancelled.
1 open finding
What changed in this PR
Consolidates CI into one required workflow with path-based mobile builds and pinned tooling.
Changes:
- Adds aggregate required-check handling.
- Converts platform/lint workflows to reusable workflows.
- Pins Bun and updates CI actions.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Orchestrates required checks and path filtering. |
.github/workflows/android.yml |
Modernizes reusable Android CI. |
.github/workflows/ios.yml |
Modernizes reusable iOS CI and caching. |
.github/workflows/lint.yml |
Modernizes reusable lint CI. |
package.json |
Pins Bun 1.4.2. |
README.md |
Replaces separate badges with one CI badge. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🟢 e2e: 14 passedAll 14 tests in 10 files
e2e 0.18.0 · 3m 32s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 8m 55s · ios · run artifacts |
troZee
reviewed
Oct 13, 2026
|
|
||
| required: | ||
| name: Required checks | ||
| needs: [changes, lint, android, ios] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR makes Android and iOS builds required checks when they should run, and skipped otherwise.
Path-filtered workflows never report when skipped, so they couldn't be required, and PRs could merge with broken native builds. CI is now one workflow with a single
Required checksgate, following Reanimated's setupTODO:
Replace the required check
Lint packagewithRequired checksonmainTest Plan
Green CI
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md