Repository navigation
fix(ios): Hide horizontal pager top scroll-edge effect - #1178
Merged
troZee merged 1 commit intoOct 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly addresses horizontal pagers while preserving existing vertical behavior.
0 open findings
What changed in this PR
Hides the iOS 26 top scroll-edge effect that obscures horizontal pager content beneath transparent headers.
Changes:
- Hides the top edge effect for all pager orientations.
- Retains remaining edge suppression for vertical pagers only.
| File | Description |
|---|---|
ios/PagerView.swift |
Adjusts iOS 26 collection-view edge-effect visibility. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Hello @erickreutz |
krozniata
approved these changes
Oct 14, 2026
troZee
enabled auto-merge (squash)
October 14, 2026 07:14
troZee
approved these changes
Oct 14, 2026
troZee
disabled auto-merge
October 14, 2026 08:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1177.
Horizontal pagers can show a full-width iOS 26 scroll-edge blur over page content beneath a transparent native-stack header. The effect belongs to the SwiftUI paging collection view, so navigator-level
scrollEdgeEffectsoptions may never reach it.Hide the collection view's top edge effect inside
PagerView's existing introspection callback on iOS 26. Keep the existing bottom, left, and right suppression limited to vertical paging, preserving the behavior added in #1149. Older iOS versions and Android are unchanged.Verified the corresponding backport to 8.0.2 in a rebuilt app on an iPhone 17 Pro simulator running iOS 26.5. Before the change, the pager rendered a visible top
ScrollEdgeEffectView; after the change, its opacity is zero and artwork remains sharp beneath the header after a clean launch and horizontal swipes. The current main-branch change has passed typecheck, formatting, and lint with no errors. Physical-device and vertical-pager runtime checks remain outstanding.