Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Child pages are still removed before deferred lifecycle destruction, and the regression lacks automated coverage.
1 open finding
What changed in this PR
Defers Android Compose pager disposal during native-stack exit animations and adds a reproduction example.
Changes:
- Defers lifecycle destruction until window detachment.
- Adds an exit-animation example and navigation routes.
- Provides test IDs for regression testing.
| File | Description |
|---|---|
ComposePagerView.kt |
Implements deferred disposal. |
ExitAnimationExample.tsx |
Adds the reproduction flow. |
App.tsx |
Registers the example routes. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if (isDisposePending) { | ||
| isDisposePending = false | ||
| composeLifecycleOwner.destroy() |
|
After: Screen.Recording.2026-10-14.at.09.34.59.mov |
🟢 e2e: 14 passedAll 14 tests in 10 files
e2e 0.18.0 · 4m 14s · android · run artifacts |
🔴 e2e: 1 failed, 12 passed🔴 basic pager › in LTR › pages horizontally ENGINE_FAILURE at step 5 of 5:
Evidence: log All 13 tests in 11 files
e2e 0.18.0 · 6m 11s · ios · run artifacts |

Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md