Repository navigation
fix(android): let nested horizontal ScrollView scroll inside pager - #1182
Merged
Merged
Conversation
🟢 e2e: 17 passedAll 17 tests in 11 files
e2e 0.18.0 · 4m 34s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 7m 47s · ios · run artifacts |
troZee
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1156
On Android, a horizontal
ScrollViewinside a page couldn't be scrolled. The pager always got the swipe firstNow, when you start swiping, the pager checks if something under your finger can scroll that way. If it can, it gets the swipe. If not, the pager moves as usual.
Nested pagers work the same way
Test Plan
Added a repro screen to the example app and an e2e test for it
All e2e should pass as expected
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility