Repository navigation
fix(deps): declare babel syntax typescript - #1483
Open
CristiCeban wants to merge 3 commits into
Open
CristiCeban wants to merge 3 commits into
CristiCeban wants to merge 3 commits into
Conversation
|
@CristiCeban is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 5682fc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CristiCeban
force-pushed
the
fix/declare-babel-syntax-typescript
branch
from
October 9, 2026 15:01
3bd8dea to
3be6620
Compare
dannyhw
pushed a commit
to callstack/super-app-showcase
that referenced
this pull request
Oct 9, 2026
Updates Re.Pack from the 5.4 canary to the stable 5.4.2 release, on top of #175. It also fixes the Release builds and gets the app building and launching on Xcode 27. Re.Pack 5.4.2 - Bumps @callstack/repack and @callstack/repack-plugin-reanimated to 5.4.2 in the catalog, host, sdk preset and docs. They're added to minimumReleaseAgeExclude until they clear the release-age gate. - Switches react-native.config.js to @callstack/repack/commands, because /commands/rspack is deprecated. - Adds @react-native/js-polyfills and @babel/plugin-syntax-typescript as direct devDependencies. Before, they only resolved through pnpm's NODE_PATH, so bundling from Xcode and Gradle failed. - @babel/plugin-syntax-typescript is a workaround until callstack/repack#1483 is released; there's a TODO next to it. Release build fixes - iOS: the bundle build phase now uses the community CLI, so Re.Pack bundles instead of RN's Metro-only scripts/bundle.js. - Android: hermesc is now found through hermes-compiler via react-native, because pnpm doesn't link it into the app's node_modules. The path includes .exe on Windows. Xcode 27 / iOS 27 - Raises pod deployment targets that Xcode 27 rejects (SDWebImage, AsyncStorage). - Adopts the UIScene lifecycle. Without it, the app crashes on launch when built with the iOS 27 SDK. Test plan - pnpm typecheck, pnpm lint, pnpm test, pnpm peers check and pnpm format:check pass. - pnpm pods then build and run: - iOS Debug / Android Debug, with pnpm start running the dev servers. - iOS Release / Android Release, with production builds of the mini apps (react-native bundle --dev false) served on ports 9001–9003. - In each of the 4 builds, from a clean install, check: - sign in as the demo user - Trading list with live prices - BTC detail with chart, then open and close the trade sheet - Wallet portfolio - Account, then sign out
dannyhw
pushed a commit
to callstack/super-app-showcase
that referenced
this pull request
Oct 9, 2026
Updates Re.Pack from the 5.4 canary to the stable 5.4.2 release, on top of #175. It also fixes the Release builds and gets the app building and launching on Xcode 27. Re.Pack 5.4.2 - Bumps @callstack/repack and @callstack/repack-plugin-reanimated to 5.4.2 in the catalog, host, sdk preset and docs. They're added to minimumReleaseAgeExclude until they clear the release-age gate. - Switches react-native.config.js to @callstack/repack/commands, because /commands/rspack is deprecated. - Adds @react-native/js-polyfills and @babel/plugin-syntax-typescript as direct devDependencies. Before, they only resolved through pnpm's NODE_PATH, so bundling from Xcode and Gradle failed. - @babel/plugin-syntax-typescript is a workaround until callstack/repack#1483 is released; there's a TODO next to it. Release build fixes - iOS: the bundle build phase now uses the community CLI, so Re.Pack bundles instead of RN's Metro-only scripts/bundle.js. - Android: hermesc is now found through hermes-compiler via react-native, because pnpm doesn't link it into the app's node_modules. The path includes .exe on Windows. Xcode 27 / iOS 27 - Raises pod deployment targets that Xcode 27 rejects (SDWebImage, AsyncStorage). - Adopts the UIScene lifecycle. Without it, the app crashes on launch when built with the iOS 27 SDK. Test plan - pnpm typecheck, pnpm lint, pnpm test, pnpm peers check and pnpm format:check pass. - pnpm pods then build and run: - iOS Debug / Android Debug, with pnpm start running the dev servers. - iOS Release / Android Release, with production builds of the mini apps (react-native bundle --dev false) served on ports 9001–9003. - In each of the 4 builds, from a clean install, check: - sign in as the demo user - Trading list with live prices - BTC detail with chart, then open and close the trade sheet - Wallet portfolio - Account, then sign out
dannyhw
pushed a commit
to callstack/super-app-showcase
that referenced
this pull request
Oct 9, 2026
Updates Re.Pack from the 5.4 canary to the stable 5.4.2 release, on top of #175. It also fixes the Release builds and gets the app building and launching on Xcode 27. Re.Pack 5.4.2 - Bumps @callstack/repack and @callstack/repack-plugin-reanimated to 5.4.2 in the catalog, host, sdk preset and docs. They're added to minimumReleaseAgeExclude until they clear the release-age gate. - Switches react-native.config.js to @callstack/repack/commands, because /commands/rspack is deprecated. - Adds @react-native/js-polyfills and @babel/plugin-syntax-typescript as direct devDependencies. Before, they only resolved through pnpm's NODE_PATH, so bundling from Xcode and Gradle failed. - @babel/plugin-syntax-typescript is a workaround until callstack/repack#1483 is released; there's a TODO next to it. Release build fixes - iOS: the bundle build phase now uses the community CLI, so Re.Pack bundles instead of RN's Metro-only scripts/bundle.js. - Android: hermesc is now found through hermes-compiler via react-native, because pnpm doesn't link it into the app's node_modules. The path includes .exe on Windows. Xcode 27 / iOS 27 - Raises pod deployment targets that Xcode 27 rejects (SDWebImage, AsyncStorage). - Adopts the UIScene lifecycle. Without it, the app crashes on launch when built with the iOS 27 SDK. Test plan - pnpm typecheck, pnpm lint, pnpm test, pnpm peers check and pnpm format:check pass. - pnpm pods then build and run: - iOS Debug / Android Debug, with pnpm start running the dev servers. - iOS Release / Android Release, with production builds of the mini apps (react-native bundle --dev false) served on ports 9001–9003. - In each of the 4 builds, from a clean install, check: - sign in as the demo user - Trading list with live prices - BTC detail with chart, then open and close the trade sheet - Wallet portfolio - Account, then sign out
CristiCeban
force-pushed
the
fix/declare-babel-syntax-typescript
branch
from
October 12, 2026 07:42
3be6620 to
8bb047d
Compare
dannyhw
reviewed
Oct 13, 2026
| for (const name of [ | ||
| linkPackage( | ||
| projectRoot, | ||
| '@react-native/babel-plugin-codegen', |
Collaborator
There was a problem hiding this comment.
should @react-native/babel-plugin-codegen be resolved in the same way or its not needed?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re.Pack passes
@babel/plugin-syntax-typescriptto Babel by name, and Babel resolves names from the project's config rather than from Re.Pack. Builds only worked when the plugin happened to be resolvable from the project. With pnpm, that usually meant theNODE_PATHset by pnpm's script shims, so builds broke when Xcode or Gradle invoked the CLI directly:Cannot find module '@babel/plugin-syntax-typescript'. Re.Pack's own tests hid this: the integration fixture linked the plugin into the project, and tester-federation-v2 declared it itself.@babel/plugin-syntax-typescriptis now a dependency of Re.Pack and is passed to Babel as a resolved path, in bothbabel-swc-loaderand the codegen rules.@babel/coreis now declared as a peer dependency, since Re.Pack's loaders import it at runtime and the syntax plugin peer-depends on it.Test plan
pnpm --filter @callstack/repack testcoversgetExtraBabelPluginsandgetCodegenTransformRulesreferencing the resolved plugin path.tests/integration(react-native-parser.test.ts) no longer links@babel/plugin-syntax-typescriptinto the fixture project; it still links@react-native/babel-plugin-codegen.@babel/plugin-syntax-typescript. Bundling its host app withoutNODE_PATH, the way Xcode and Gradle do, still compiles: