Repository navigation
docs(adr): 0030 optional modules share one contract and load only when turned on - #592
Merged
Merged
Conversation
This was referenced Oct 15, 2026
V3RON
added this pull request to stack #600
October 15, 2026 11:19
V3RON
marked this pull request as ready for review
October 15, 2026 13:37
V3RON
force-pushed
the
feature/591-adr
branch
from
October 15, 2026 13:39
2ea3dff to
8d6cebc
Compare
…he name, concurrent stop steps
…tp helpers and bus types
V3RON
force-pushed
the
feature/591-adr
branch
from
October 15, 2026 16:43
8d6cebc to
057484b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes ADR 0030 for #591 (optional modules share one contract and load only when turned on). It narrows ADR 0023 §3.
It decides:
definition.tsand one line insrc/modules/registry.ts. Its one name is its capability, its relay target, its doctormodulefield and, in camelCase, its config key.off. A leftover agent-device daemon is no longer reaped while agent-device is off.createWorker(ctx)returns a handle: what the module provides, plushooksnamed for the host step they run at (afterSocketClaimed,beforeDeviceReclaim,beforeDrain,beforeDriversDispose). The host bounds them from one table.main.ts.ModuleMountlives insrc/modules, so no module importssrc/http.agent-device-unavailablebecomesmodule-unavailablewithmodule. The protocol goes from 36 to 37.Stays open as the bottom of #591's stack until the feature's last task merges.
Status
Assumptions
None.
Review
Spec review: skipped. Code review: skipped. Claims review: skipped.
Rounds: 0. Tokens: 0M.
The maintainer accepted the ADR directly; no review run was recorded on this PR.
Written by an agent.