feat(charms): wire the async replication subsystem into the charm composition root (5/8) - #281
Draft
marceloneppel wants to merge 1 commit into
Draft
Conversation
marceloneppel
force-pushed
the
async-replication-4-events-flows
branch
from
September 4, 2026 23:07
1dffc73 to
d1b2d71
Compare
marceloneppel
force-pushed
the
async-replication-5-wiring
branch
from
September 4, 2026 23:07
2e72d8d to
7cec1a1
Compare
…position root (5/8)
marceloneppel
force-pushed
the
async-replication-4-events-flows
branch
from
September 4, 2026 23:22
d1b2d71 to
7511e75
Compare
marceloneppel
force-pushed
the
async-replication-5-wiring
branch
from
September 4, 2026 23:22
7cec1a1 to
fcb3a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Connects the ported subsystem to the composition root, mirroring how the LDAP and database modules are wired.
Solution
AbstractPostgreSQLCharmconstructsK8sManager(K8s substrate only, lazy import so the VM import graph never pulls lightkube),AsyncReplicationManagerandPostgreSQLAsyncReplication; thek8s_managerconstruction moves out ofPostgreSQLK8sCharm.set_app_status(status)(the production charms keep their refresh-priority/can_set_app_statusgates behind it) andset_primary_status_message()(the VM_set_primary_status_message/ K8s_set_active_statusequivalents); minimal implementations in the library's VM/K8s charms plus K8s-onlyfix_leader_annotation/create_pgdatastubs.events/postgresql.pyguards the pre-existingcharm.k8s_manager.update_pebble_layers()call against the now-Optional manager.