Add InitiatorAddr::Eoa#5427
Open
mpapierski wants to merge 1 commit into
Open
Conversation
mpapierski
requested review from
EdHastingsCasperAssociation,
darthsiroftardis and
zajko
July 14, 2026 12:47
mpapierski
changed the title
Comment on lines
+79
to
+84
| let Some(account_hash) = initiator_addr.account_hash() else { | ||
| return WasmV1Result::precondition_failure( | ||
| gas_limit, | ||
| Error::TrackingCopy(TrackingCopyError::Authorization), | ||
| ); | ||
| }; |
Collaborator
There was a problem hiding this comment.
good thinking. Auth error is the right call.
EdHastingsCasperAssociation
approved these changes
Jul 17, 2026
EdHastingsCasperAssociation
left a comment
EdHastingsCasperAssociation
left a comment
Collaborator
There was a problem hiding this comment.
i like this a lot better than the initial version, well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of several changes discussed during our EVM review session.
EvmTransactioncurrently stores anInitiatorAddreven though the transaction already contains the Ethereum sender infrom. This is awkward forcasper-sidecar, especially foreth_calljsonrpc, because it has an EVM address but no meaningful Casper account hash to provide.This PR adds
InitiatorAddr::Eoa(Address)and derives the EVM transaction initiator directly fromfromfield. This simplifies some flows i.e. identity link resolution etc.