Repository navigation
Add StrictBox to reject new fields in attribute assignments - #352
Closed
Aschenbath wants to merge 1 commit into
Closed
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute assignments can silently create misspelled fields, while freezing a Box also prevents legitimate value updates. Add StrictBox, which allows attribute writes only to existing fields; item assignment and dictionary methods can explicitly add fields. Nested boxes inherit this behavior, including existing aliases, dotted paths, default values, copying and pickling. Fixes #147.
Validation: 754 tests passed and 1 skipped on Python 3.12, Python 3.14, and the installed Cython wheel. The Python 3.12 suite reaches 100% line and branch coverage. Pinned Ruff, mypy, wheel/sdist builds and Twine checks pass. An independent AI reviewer exercised 21 additional cases and reported no remaining blocker.
Scope follows the original request for dot assignments: dictionary methods may add fields and replacing a nested dictionary may change its fields. This does not perform schema or value-type validation. Local runs used Linux musl; Windows and macOS validation is left to CI.
OpenAI Codex implemented the change, ran the checks, and wrote this description. A separate Codex agent reviewed the implementation; no human review is claimed.