Repository navigation
Preserve one-shot pairs in ConfigBox.merge_update - #353
Merged
cdgriffith merged 1 commit intoNov 11, 2026
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigBox.merge_update([iter(("host", {"name": "localhost"}))])raisesValueErrorbecause case normalization unpacks each pair before the underlying merge reads it again. This also changes the existing key's spelling before the merge fails.Materialize the inner pairs as well as the outer iterable so both passes see the same keys and values. Tests cover list and iterator outer inputs, merging nested configuration, the updated key spelling, and case-insensitive lookup. Both tests fail before the fix.
Validation on Linux, Python 3.12.14: full pure-Python suite, 697 passed and 1 skipped; Ruff lint and formatting, mypy, and
git diff --checkpass. Cython builds were not tested.AI disclosure: investigated, implemented and tested with OpenAI Codex.