Repository navigation
Apply configured insertion rules in Box.update - #360
Merged
cdgriffith merged 2 commits intoNov 13, 2026
Merged
cdgriffith merged 2 commits into
cdgriffith merged 2 commits into
Conversation
# Conflicts: # CHANGES.rst
cdgriffith
added a commit
that referenced
this pull request
Nov 13, 2026
Apply configured insertion rules in Box.update # Conflicts: # CHANGES.rst
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Box.updatebypasses the assignment boundary for ordinary keys. Withbox_recast={"batch_size": int}, updatingbatch_sizeto"12"stores a string; withcamel_killer_box=True, updatingTimeOutleaves both the oldtime_outvalue and a newTimeOutkey. Union operators inherit the same behavior.Route update insertions through
__setitem__so recasting, key conversion, duplicate checks and subclass assignment hooks match single-item assignment. Nested values still replace existing values, and dotted paths keep their existing routing.The regression tests cover mapping/pair/keyword updates, unions, recast failures and call counts, camel key policies, duplicate policies, ConfigBox and subclass dispatch. The existing exact-key lookup test now constructs its raw-key collision explicitly; its assertions are unchanged.
Validation on macOS arm64, CPython 3.14.7:
twine checkpass.Other Python versions and CI platforms were not run locally. This change was prepared with OpenAI Codex.