Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without ruamel.yaml or PyYAML installed,
box_from_string(content, string_type="yaml")raisesTypeError: catching classes that do not inherit from BaseException is not allowedin the pure Python build. When neither library can be imported,from_file.pysetsYAMLError = False, and the yaml branch wrapsBox.from_yaml(), which then raisesBoxError, inexcept YAMLError:. Python fails while matching that clause. The Cython compiled wheels don't show this, because there the clause simply doesn't match and theBoxList.from_yaml()fallback raises theBoxError, so it only happens with the pure Python wheel or sdist, for example on PyPy or on platforms without a compiled wheel.This adds the availability check that the toon branch already has, with the message
Box.from_yaml()uses, so both builds now raise the sameBoxError. The new test puts the module into the no-YAML state the same waytest_toon_unavailabledoes, and fails with theTypeErrorwithout the change.I reproduced the error and checked the fix in a venv without any YAML library, and ran the full test suite, ruff and mypy locally on Windows with Python 3.14.