Repository navigation
Avoid per-element copies when iterating repeated proto fields. - #2405
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1005746075
branch
4 times, most recently
from
October 26, 2026 20:01
30bd99b to
d9413ee
Compare
copybara-service
Bot
changed the title
`ParsedRepeatedFieldValue::NewIterator`, `ForEach`, and `Contains` now borrow elements of unsafe containers, matching `Get`. `FromLegacyList` evaluates a `FieldBackedListImpl` over a heap-allocated message as an `UnsafeParsedRepeatedFieldValue`, so repeated fields bound with `BindProtoToActivation` take the same path. PiperOrigin-RevId: 1005746075
copybara-service
Bot
force-pushed
the
test_1005746075
branch
from
October 26, 2026 20:35
d9413ee to
d64dd43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid per-element copies when iterating repeated proto fields.
ParsedRepeatedFieldValue::NewIterator,ForEach, andContainsnow borrowelements of unsafe containers, matching
Get.FromLegacyListevaluates aFieldBackedListImplover a heap-allocated message as anUnsafeParsedRepeatedFieldValue, so repeated fields bound withBindProtoToActivationtake the same path.