build(pnpm): resolve pnpm from devEngines, align engines with the policy - #339
Merged
Merged
Conversation
engines.node and engines.npm now match .github/node-policy.conf in rtldev-middleware-workspace, and the pnpm version is declared once, as a range, in devEngines.packageManager rather than left to whatever pnpm CI installed last. devEngines validates instead of switching: a pnpm outside the range fails the command by name, where packageManager made pnpm silently download and re-execute itself as one exact version. Declaring it also makes pnpm lock itself — the packageManagerDependencies document in pnpm-lock.yaml is that resolution, and pnpm i --frozen-lockfile fails until it is committed, which is why the lockfile moves in this commit too. The caller workflows pass pnpm-version: "" so pnpm/action-setup resolves the version from this manifest rather than installing whatever pnpm is newest. RSRMID-3008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Node/npm/pnpm toolchain alignment in RSRMID-3008.
engines.nodeandengines.npmnow match.github/node-policy.confinrtldev-middleware-workspace, and the pnpm version is declared once, as a range, indevEngines.packageManager.devEnginesvalidates instead of switching: a pnpm outside the range fails the commandby name, where
packageManagermade pnpm silently download and re-execute itself as oneexact version. Declaring it also makes pnpm lock itself — the
packageManagerDependenciesdocument in
pnpm-lock.yamlis that resolution, andpnpm i --frozen-lockfilefailsuntil it is committed, which is why the lockfile moves here too. The lockfile diff is
purely that document; no resolved dependency version changes.
The caller workflows pass
pnpm-version: ""sopnpm/action-setupresolves the versionfrom this manifest rather than installing whatever pnpm is newest.
Merge order
This one is independent — it can merge as soon as CI is green. The
rtldev-middleware-shareable-workflowsPR in this set must merge after everymanifest PR, because it inverts the
pnpm-versiondefault.